Issue 1548002: Add -b option to run_remote_tests to build tests before running

Issue 1548002: Add -b option to run_remote_tests to build tests before running (Closed)

Created:
10 years, 9 months ago by kmixter1

Modified:
9 years, 7 months ago

Reviewers:
petkov, ericli

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Add -b option to run_remote_tests to build tests before running

Patch Set 1 #

Total comments: 3

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -12 lines)			Patch
	M	src/scripts/run_remote_tests.sh	View		9 chunks	+69 lines, -12 lines	3 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ericli

http://codereview.chromium.org/1548002/diff/1/2 File src/scripts/run_remote_tests.sh (right): http://codereview.chromium.org/1548002/diff/1/2#newcode251 src/scripts/run_remote_tests.sh:251: build_param="${build_param}${simple_path}" I think it needs to be seperated by ...

10 years, 9 months ago (2010-03-29 21:33:22 UTC) #2

petkov

LGTM http://codereview.chromium.org/1548002/diff/1/2 File src/scripts/run_remote_tests.sh (right): http://codereview.chromium.org/1548002/diff/1/2#newcode133 src/scripts/run_remote_tests.sh:133: local type=$(egrep '^[[:space:]]*TEST_TYPE[[:space:]]*=' "${control_file}" \ You could use ...

10 years, 9 months ago (2010-03-29 21:37:38 UTC) #3

kmixter1

On Mon, Mar 29, 2010 at 2:33 PM, <ericli@chromium.org> wrote: > > http://codereview.chromium.org/1548002/diff/1/2 > File ...

10 years, 9 months ago (2010-03-29 23:17:40 UTC) #4

ericli

10 years, 9 months ago (2010-03-30 00:01:44 UTC) #5

LGTM.

On Mon, Mar 29, 2010 at 4:17 PM, Ken Mixter <kmixter@chromium.org> wrote:

> On Mon, Mar 29, 2010 at 2:33 PM,  <ericli@chromium.org> wrote:
> >
> > http://codereview.chromium.org/1548002/diff/1/2
> > File src/scripts/run_remote_tests.sh (right):
> >
> > http://codereview.chromium.org/1548002/diff/1/2#newcode251
> > src/scripts/run_remote_tests.sh:251:
> > build_param="${build_param}${simple_path}"
> > I think it needs to be seperated by comma, if there are multiple tests
> > to build.
>
> Yes it does - see a few lines above 251.
>
> >
> > http://codereview.chromium.org/1548002
> >
>



-- 
Eric Li
李咏竹
Google Kirkland

Expand Messages | Collapse Messages