Issue 1547010: Set bookmark bar menu windows to the correct level....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1547010: Set bookmark bar menu windows to the correct level.... (Closed)

Created:
10 years, 8 months ago by John Grabowski

Modified:
9 years, 6 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, John Grabowski, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Set bookmark bar menu windows to the correct level. Fixes some menu awkwardness (e.g. is below the menubar and dock). Fixes some scroll awkwardness related dock overlap. Does NOT cause awkwardness if you Expose' which is smart enough to hide popup menus when exposeeing. BUG=http://crbug.com/36225 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43303

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -12 lines)			Patch
M	chrome/browser/cocoa/bookmark_bar_folder_controller.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_bar_folder_controller.mm	View	3 chunks	+7 lines, -10 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm	View	3 chunks	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.  Thanks for thinking of the unit tests!

Expand Messages | Collapse Messages