Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 1547010: Set bookmark bar menu windows to the correct level.... (Closed)

Created:
10 years, 8 months ago by John Grabowski
Modified:
9 years, 6 months ago
Reviewers:
Miranda Callahan
CC:
chromium-reviews, John Grabowski, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Set bookmark bar menu windows to the correct level. Fixes some menu awkwardness (e.g. is below the menubar and dock). Fixes some scroll awkwardness related dock overlap. Does NOT cause awkwardness if you Expose' which is smart enough to hide popup menus when exposeeing. BUG=http://crbug.com/36225 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43303

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -12 lines) Patch
M chrome/browser/cocoa/bookmark_bar_folder_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/cocoa/bookmark_bar_folder_controller.mm View 3 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm View 3 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
John Grabowski
10 years, 8 months ago (2010-04-01 00:52:48 UTC) #1
Miranda Callahan
10 years, 8 months ago (2010-04-01 00:59:01 UTC) #2
LGTM.  Thanks for thinking of the unit tests!

Powered by Google App Engine
This is Rietveld 408576698