Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Unified Diff: chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm

Issue 1547010: Set bookmark bar menu windows to the correct level.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/bookmark_bar_folder_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm
===================================================================
--- chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm (revision 43292)
+++ chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm (working copy)
@@ -24,7 +24,18 @@
}
@end
+// Don't use a high window level when running unit tests -- it'll
+// interfere with anything else you are working on.
+@interface BookmarkBarFolderControllerLow : BookmarkBarFolderController
+@end
+@implementation BookmarkBarFolderControllerLow
+- (void)configureWindowLevel {
+ // Intentionally empty.
+}
+@end
+
+
@interface BookmarkBarFolderControllerPong : BookmarkBarFolderController {
BOOL childFolderWillShow_;
BOOL childFolderWillClose_;
@@ -155,7 +166,7 @@
// If parent is a BookmarkBarController, grow down.
scoped_nsobject<BookmarkBarFolderController> bbfc;
- bbfc.reset([[BookmarkBarFolderController alloc]
+ bbfc.reset([[BookmarkBarFolderControllerLow alloc]
initWithParentButton:parentButton
parentController:parentBarController_]);
NSPoint pt = [bbfc windowTopLeft];
@@ -163,7 +174,7 @@
// If parent is a BookmarkBarFolderController, grow right.
scoped_nsobject<BookmarkBarFolderController> bbfc2;
- bbfc2.reset([[BookmarkBarFolderController alloc]
+ bbfc2.reset([[BookmarkBarFolderControllerLow alloc]
initWithParentButton:[[bbfc buttons] objectAtIndex:0]
parentController:bbfc.get()]);
pt = [bbfc2 windowTopLeft];
« no previous file with comments | « chrome/browser/cocoa/bookmark_bar_folder_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698