Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1547009: Change ui_tests to pull the directories it needs from the upstream webkit (Closed)

Created:
10 years, 8 months ago by Dirk Pranke
Modified:
9 years, 7 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews
Visibility:
Public.

Description

Change ui_tests to pull the directories it needs from the upstream webkit tree directly rather than relying on webkit/data/layout_tests for the baselines. This requires us to change a few spots in the source code because the directory naming conventions for platform-specific baselines is different upstream (it's platform/chromium-win/foo rather than platform/chromium-win/LayoutTests/foo). Once this test lands we can (in theory) remove the downstream layout test baselines. BUG=none TEST=none R=dimich@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43557

Patch Set 1 #

Total comments: 1

Patch Set 2 : update w/ feedback from dtitov #

Patch Set 3 : fix path for web socket tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -11 lines) Patch
M DEPS View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/in_process_webkit/dom_storage_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/ui/ui_layout_test.cc View 4 chunks +12 lines, -4 lines 0 comments Download
M chrome/worker/worker_uitest.cc View 1 2 5 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Titov
http://codereview.chromium.org/1547009/diff/1/4 File chrome/test/ui/ui_layout_test.cc (right): http://codereview.chromium.org/1547009/diff/1/4#newcode44 chrome/test/ui/ui_layout_test.cc:44: void UILayoutTest::InitializeForLayoutTest(const FilePath& test_parent_dir, this method is called in ...
10 years, 8 months ago (2010-04-01 21:40:04 UTC) #1
Dirk Pranke
On 2010/04/01 21:40:04, Dmitry Titov wrote: > http://codereview.chromium.org/1547009/diff/1/4 > File chrome/test/ui/ui_layout_test.cc (right): > > http://codereview.chromium.org/1547009/diff/1/4#newcode44 ...
10 years, 8 months ago (2010-04-01 22:51:16 UTC) #2
Dmitry Titov
10 years, 8 months ago (2010-04-01 23:34:06 UTC) #3
LGTM

One thing - I see there is also chromium-mac/http/tests/workers upstream with a
single expectations file. If it's a dupe, lets file a bug in webkit to remove
it.

Powered by Google App Engine
This is Rietveld 408576698