Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: chrome/test/ui/ui_layout_test.cc

Issue 1547009: Change ui_tests to pull the directories it needs from the upstream webkit (Closed)
Patch Set: fix path for web socket tests Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/in_process_webkit/dom_storage_uitest.cc ('k') | chrome/worker/worker_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ui/ui_layout_test.cc
diff --git a/chrome/test/ui/ui_layout_test.cc b/chrome/test/ui/ui_layout_test.cc
index 8c3139425b3179b89c7b4d5bea970d24c527b903..f5be28d63195bac7b9a0408556b31f7f5e137c7e 100644
--- a/chrome/test/ui/ui_layout_test.cc
+++ b/chrome/test/ui/ui_layout_test.cc
@@ -55,16 +55,19 @@ void UILayoutTest::InitializeForLayoutTest(const FilePath& test_parent_dir,
layout_test_dir_ = layout_test_dir_.AppendASCII("test");
layout_test_dir_ = layout_test_dir_.AppendASCII("data");
layout_test_dir_ = layout_test_dir_.AppendASCII("layout_tests");
+ layout_test_dir_ = layout_test_dir_.AppendASCII("LayoutTests");
layout_test_dir_ = layout_test_dir_.Append(test_parent_dir);
layout_test_dir_ = layout_test_dir_.Append(test_case_dir);
ASSERT_TRUE(file_util::DirectoryExists(layout_test_dir_));
// Gets the file path to rebased expected result directory for the current
// platform.
- // webkit/data/layout_tests/platform/chromium_***/LayoutTests/...
- rebase_result_dir_ = src_dir.AppendASCII("webkit");
+ // chrome/test/data/layout_tests/LayoutTests/platform/chromium_***/...
+ rebase_result_dir_ = src_dir.AppendASCII("chrome");
+ rebase_result_dir_ = rebase_result_dir_.AppendASCII("test");
rebase_result_dir_ = rebase_result_dir_.AppendASCII("data");
rebase_result_dir_ = rebase_result_dir_.AppendASCII("layout_tests");
+ rebase_result_dir_ = rebase_result_dir_.AppendASCII("LayoutTests");
rebase_result_dir_ = rebase_result_dir_.AppendASCII("platform");
rebase_result_dir_ = rebase_result_dir_.AppendASCII(kPlatformName);
rebase_result_dir_ = rebase_result_dir_.Append(test_parent_dir);
@@ -74,9 +77,11 @@ void UILayoutTest::InitializeForLayoutTest(const FilePath& test_parent_dir,
// win32 platform. This is used by other non-win32 platform to use the same
// rebased expected results.
#if !defined(OS_WIN)
- rebase_result_win_dir_ = src_dir.AppendASCII("webkit");
+ rebase_result_win_dir_ = src_dir.AppendASCII("chrome");
+ rebase_result_win_dir_ = rebase_result_win_dir_.AppendASCII("test");
rebase_result_win_dir_ = rebase_result_win_dir_.AppendASCII("data");
rebase_result_win_dir_ = rebase_result_win_dir_.AppendASCII("layout_tests");
+ rebase_result_win_dir_ = rebase_result_win_dir_.AppendASCII("LayoutTests");
rebase_result_win_dir_ = rebase_result_win_dir_.AppendASCII("platform");
rebase_result_win_dir_ = rebase_result_win_dir_.AppendASCII("chromium-win");
rebase_result_win_dir_ = rebase_result_win_dir_.Append(test_parent_dir);
@@ -92,6 +97,7 @@ void UILayoutTest::InitializeForLayoutTest(const FilePath& test_parent_dir,
// like .../LayoutTests/fast/workers/.... Otherwise those layout tests
// dealing with location property, like worker-location.html, could fail.
new_layout_test_dir_ = temp_test_dir_;
+ new_layout_test_dir_ = new_layout_test_dir_.AppendASCII("LayoutTests");
new_layout_test_dir_ = new_layout_test_dir_.Append(test_parent_dir);
if (port == kHttpPort) {
new_http_root_dir_ = new_layout_test_dir_;
@@ -139,11 +145,13 @@ void UILayoutTest::AddResourceForLayoutTest(const FilePath& parent_dir,
src_dir = src_dir.AppendASCII("test");
src_dir = src_dir.AppendASCII("data");
src_dir = src_dir.AppendASCII("layout_tests");
+ src_dir = src_dir.AppendASCII("LayoutTests");
src_dir = src_dir.Append(parent_dir);
src_dir = src_dir.Append(resource_dir);
ASSERT_TRUE(file_util::DirectoryExists(src_dir));
- FilePath dest_parent_dir = temp_test_dir_.Append(parent_dir);
+ FilePath dest_parent_dir = temp_test_dir_.
+ AppendASCII("LayoutTests").Append(parent_dir);
ASSERT_TRUE(file_util::CreateDirectory(dest_parent_dir));
FilePath dest_dir = dest_parent_dir.Append(resource_dir);
ASSERT_TRUE(file_util::CopyDirectory(src_dir, dest_dir, true));
« no previous file with comments | « chrome/browser/in_process_webkit/dom_storage_uitest.cc ('k') | chrome/worker/worker_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698