Issue 1542006: Roll gyp for make generator updates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1542006: Roll gyp for make generator updates. (Closed)

Created:
10 years, 8 months ago by Michael Moss

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Visibility:
Public.

Description

Roll gyp for make generator updates. TBR=thestig

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bradn

10 years, 8 months ago (2010-04-02 17:17:12 UTC) #4

LGTM

On Tue, Mar 30, 2010 at 10:36 AM, <mmoss@chromium.org> wrote:

> Reviewers: bradnelson,
>
> Description:
> Roll gyp for make generator updates.
>
> Please review this at http://codereview.chromium.org/1542006
>
> Affected files:
>  M DEPS
>
>
> Index: DEPS
> diff --git a/DEPS b/DEPS
> index
>
dc451b947ad66b5fc3ae3ea5b1251e8c3fad15f2..7d7dcaecbfbdbf883c3abf04b080c206f8ae2524
> 100644
> --- a/DEPS
> +++ b/DEPS
> @@ -38,7 +38,7 @@ deps = {
>     "http://protobuf.googlecode.com/svn/trunk@305",
>
>   "src/tools/gyp":
> -    "http://gyp.googlecode.com/svn/trunk@805",
> +    "http://gyp.googlecode.com/svn/trunk@808",
>
>   "src/v8":
>     "http://v8.googlecode.com/svn/trunk@4328",
>
>
>

Expand Messages | Collapse Messages