Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1528012: Notify all active login prompts when one login prompt is submitted. This allo... (Closed)

Created:
10 years, 8 months ago by tonyg
Modified:
9 years, 6 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, pam+watch_chromium.org, John Grabowski, Paweł Hajdan Jr., darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Notify all active login prompts when one login prompt is submitted. This allows identical login prompts to dismiss themselves. This was originally submitted as r42770 but had to be rolled back because I copied from a FLAKY test. Now that r43266 fixed the flakiness, this should be good to go. The code is exactly the same as r42770 with one exception. I added a WaitForNavigation guard to the tab the other tab in the new test cases. This could have also caused flakiness in the initial revision. BUG=8914 TEST=ui_tests --gtest_filter=LoginPromptTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43374

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -46 lines) Patch
M chrome/browser/automation/automation_provider_observers.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/login_prompt.h View 6 chunks +64 lines, -7 lines 0 comments Download
M chrome/browser/login_prompt.cc View 10 chunks +123 lines, -24 lines 0 comments Download
M chrome/browser/login_prompt_gtk.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/login_prompt_mac.mm View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/login_prompt_uitest.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M chrome/browser/login_prompt_win.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/common/notification_type.h View 1 chunk +10 lines, -1 line 0 comments Download
M net/base/auth.h View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tonyg
10 years, 8 months ago (2010-04-01 17:45:27 UTC) #1
Elliot Glaysher
10 years, 8 months ago (2010-04-01 19:22:37 UTC) #2
Rubber stamp.

On Thu, Apr 1, 2010 at 10:45 AM,  <tonyg@chromium.org> wrote:
> Reviewers: Elliot Glaysher,
>
> Description:
> Notify all active login prompts when one login prompt is submitted. This
> allows
> identical login prompts to dismiss themselves.
>
> This was originally submitted as r42770 but had to be rolled back because I
> copied from a FLAKY test. Now that r43266 fixed the flakiness, this should
> be
> good to go.
>
> The code is exactly the same as r42770 with one exception. I added a
> WaitForNavigation guard to the tab the other tab in the new test cases. This
> could have also caused flakiness in the initial revision.
>
> BUG=8914
> TEST=ui_tests --gtest_filter=LoginPromptTest.*
>
>
> Please review this at http://codereview.chromium.org/1528012
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/automation/automation_provider_observers.cc
>  M     chrome/browser/login_prompt.h
>  M     chrome/browser/login_prompt.cc
>  M     chrome/browser/login_prompt_gtk.cc
>  M     chrome/browser/login_prompt_mac.mm
>  M     chrome/browser/login_prompt_uitest.cc
>  M     chrome/browser/login_prompt_win.cc
>  M     chrome/common/notification_type.h
>  M     net/base/auth.h
>
>
>

Powered by Google App Engine
This is Rietveld 408576698