Issue 1528011: Pull in ICU@43139 and remove icudt42.dll from the exception list in checkbins...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1528011: Pull in ICU@43139 and remove icudt42.dll from the exception list in checkbins... (Closed)

Created:
10 years, 8 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
jschuh, scherkus (not reviewing)

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Pull in ICU@43139 and remove icudt42.dll from the exception list in checkbins.py (see http://codereview.chromium.org/1523002 ) BUG=39303 TEST=checkbins.py doesn't complain about third_party/icu/icudt42.dll Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43226

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/checkbins/checkbins.py	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

LGTM