Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1523002: Build icudt42.dll with /NXCOMPAT /DYNAMICBASE for real by ... (Closed)

Created:
10 years, 8 months ago by jungshik at Google
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Build icudt42.dll with /NXCOMPAT /DYNAMICBASE for real by patching makedata.mak. BUG=39303 TEST=run dumpbin /headers icudt42.dll and it has the output in comment 15. TBR=jschuh Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43139

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M third_party/icu/icudt42.dll View Binary file 0 comments Download
M third_party/icu/patches/data.build.win.patch View 3 chunks +15 lines, -2 lines 0 comments Download
M third_party/icu/source/data/makedata.mak View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jungshik at Google
10 years, 8 months ago (2010-03-30 21:59:09 UTC) #1
jschuh
LGTM. Thanks for taking care of it so quickly.
10 years, 8 months ago (2010-03-30 22:16:57 UTC) #2
scherkus (not reviewing)
10 years, 8 months ago (2010-03-30 22:20:14 UTC) #3
cool!!

Powered by Google App Engine
This is Rietveld 408576698