Additional changes to support Chrome / CF installation wrapped in an MSI:...

Additional changes to support Chrome / CF installation wrapped in an MSI:

Disables start menu uninstall shortcuts.
Tweaks quoting of uninstall command to follow msi ca rules. 
Adds a ClientState registry entry to flag that this installation is managed by an MSI.
Set said registry flag on first MSI install.

BUG=19370
TEST=Install with generated MSI, upgrade, uninstall.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45802

[robertshield, 2010-04-21 16:00:34]

Hi Huan,

  Please could you review this set of changes to get Chrome / CF running happily
wrapped in an MSI?

Thanks!
Robert

[huanr, 2010-04-22 22:41:12]

http://codereview.chromium.org/1525042/diff/9001/10004
File chrome/installer/util/install_util.cc (right):

http://codereview.chromium.org/1525042/diff/9001/10004#newcode33
chrome/installer/util/install_util.cc:33: bool InstallUtil::msi_checked_ =
false;
Installer util is linked into Chrome as well. To avoid unnecessary
initialization, can you define is_msi_ and msi_checked_ as static viables in
IsMSIProcess()?

[robertshield, 2010-04-26 21:20:26]

Thanks, please could you take another look. (Sorry for the delay on this).

http://codereview.chromium.org/1525042/diff/9001/10004
File chrome/installer/util/install_util.cc (right):

http://codereview.chromium.org/1525042/diff/9001/10004#newcode33
chrome/installer/util/install_util.cc:33: bool InstallUtil::msi_checked_ =
false;
On 2010/04/22 22:41:13, huanr wrote:
> Installer util is linked into Chrome as well. To avoid unnecessary
> initialization, can you define is_msi_ and msi_checked_ as static viables in
> IsMSIProcess()?

Done.

[huanr, 2010-04-26 23:00:05]

LGTM