Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1555)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 1525042: Additional changes to support Chrome / CF installation wrapped in an MSI:... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/util/google_update_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/uninstall.cc
===================================================================
--- chrome/installer/setup/uninstall.cc (revision 45608)
+++ chrome/installer/setup/uninstall.cc (working copy)
@@ -339,14 +339,16 @@
}
bool ShouldDeleteProfile(const CommandLine& cmd_line,
- installer_util::InstallStatus status) {
+ installer_util::InstallStatus status,
+ bool system_uninstall) {
bool should_delete = false;
// Chrome Frame uninstallations always want to delete the profile (we have no
// UI to prompt otherwise and the profile stores no useful data anyway)
// unless they are managed by MSI. MSI uninstalls will explicitly include
// the --delete-profile flag to distinguish them from MSI upgrades.
- if (InstallUtil::IsChromeFrameProcess() && !InstallUtil::IsMSIProcess()) {
+ if (InstallUtil::IsChromeFrameProcess() &&
+ !InstallUtil::IsMSIProcess(system_uninstall)) {
should_delete = true;
} else {
should_delete =
@@ -569,7 +571,7 @@
// Finally delete all the files from Chrome folder after moving setup.exe
// and the user's Local State to a temp location.
- bool delete_profile = ShouldDeleteProfile(cmd_line, status);
+ bool delete_profile = ShouldDeleteProfile(cmd_line, status, system_uninstall);
std::wstring local_state_path;
ret = installer_util::UNINSTALL_SUCCESSFUL;
« no previous file with comments | « chrome/installer/setup/setup_main.cc ('k') | chrome/installer/util/google_update_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698