Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 1521012: Add a --to option to build_image (Closed)

Created:
10 years, 8 months ago by piman
Modified:
9 years, 7 months ago
Reviewers:
Bill Richardson, adlr
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Add a --to option to build_image That way we can directly build an image onto a usb stick/sd card without a separate step. Also, add mounting of /sys into the chroot that is needed by build_gpt on a block device.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M src/scripts/build_gpt.sh View 1 chunk +11 lines, -4 lines 1 comment Download
M src/scripts/build_image View 2 chunks +3 lines, -1 line 0 comments Download
M src/scripts/enter_chroot.sh View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
piman
10 years, 8 months ago (2010-04-01 22:42:37 UTC) #1
adlr
LGTM w/ comment http://codereview.chromium.org/1521012/diff/1/2 File src/scripts/build_gpt.sh (right): http://codereview.chromium.org/1521012/diff/1/2#newcode148 src/scripts/build_gpt.sh:148: if [ ! -w "$OUTDEV" ] ...
10 years, 8 months ago (2010-04-01 22:47:07 UTC) #2
piman
On Thu, Apr 1, 2010 at 3:47 PM, <adlr@chromium.org> wrote: > LGTM w/ comment > ...
10 years, 8 months ago (2010-04-01 22:53:20 UTC) #3
adlr
10 years, 8 months ago (2010-04-01 22:54:53 UTC) #4
On Thu, Apr 1, 2010 at 3:52 PM, Antoine Labour <piman@chromium.org> wrote:

>
>
> On Thu, Apr 1, 2010 at 3:47 PM, <adlr@chromium.org> wrote:
>
>> LGTM w/ comment
>>
>>
>> http://codereview.chromium.org/1521012/diff/1/2
>> File src/scripts/build_gpt.sh (right):
>>
>> http://codereview.chromium.org/1521012/diff/1/2#newcode148
>> src/scripts/build_gpt.sh:148: if [ ! -w "$OUTDEV" ] ; then
>> maybe [ -b "$OUTDEV" ] is better?
>> -b means "it is a block device"
>
>
> Argument is, if you can't write to it as a user (for any reason), try it as
> root. That way if the user has permission to the block device, it works
> without sudo.
>
>
ah, sounds fine


>
>>
>> http://codereview.chromium.org/1521012
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698