New Full AU Format w/ support for kernel partition.

New Full AU Format w/ support for kernel partition.

The old format was: gzip(root filesystem). The new format is:
gzip(kernel parition length + kernel partition + root filesystem). The
length is 8 bytes (uint64 big endian).

This CL fixes the updater and the update generator to support the new
format.

[sosa, 2010-04-09 16:15:22]

My only major concern with split_write is I'd much rather have you close the fd
properly and not exit early in the many functions you call.  Can you refactor
some and send error codes in the functions and handle it close the fd's
gracefully at the end of main.

http://codereview.chromium.org/1520028/diff/1/4
File src/platform/memento_softwareupdate/memento_updater.sh (right):

http://codereview.chromium.org/1520028/diff/1/4#newcode150
src/platform/memento_softwareupdate/memento_updater.sh:150: log "kernel install
dev the same as install dev! (${KINSTALL_DEV})"
Can you be a little more specific here and just say partition rather than
device?  Easier to read the log and matches with the comments

http://codereview.chromium.org/1520028/diff/1/5
File src/platform/memento_softwareupdate/split_write.cc (right):

http://codereview.chromium.org/1520028/diff/1/5#newcode104
src/platform/memento_softwareupdate/split_write.cc:104: exit(0);
exit 0 vs exit 1?  Ok to specify more size for the first file than exists in
stdin?

http://codereview.chromium.org/1520028/diff/1/5#newcode115
src/platform/memento_softwareupdate/split_write.cc:115: close(fd1);
Shouldn't you always close your files ... you seem to prematurely exit a lot and
wouldn't call close.

http://codereview.chromium.org/1520028/diff/1/6
File src/scripts/mk_memento_images.sh (right):

http://codereview.chromium.org/1520028/diff/1/6#newcode13
src/scripts/mk_memento_images.sh:13: if [ -z "$2" -o -z "$1" ]; then
Can you have a -z $1 but not -z $2?  I would think you'd only need to check if
there's a second argument since that implies there's a first

http://codereview.chromium.org/1520028/diff/1/6#newcode29
src/scripts/mk_memento_images.sh:29: echo "Kernel partition size ($KPART_SIZE
bytes) greater than 16 MiB."
MB*

[adlr, 2010-04-09 19:36:45]

PTAL thanks

http://codereview.chromium.org/1520028/diff/1/4
File src/platform/memento_softwareupdate/memento_updater.sh (right):

http://codereview.chromium.org/1520028/diff/1/4#newcode150
src/platform/memento_softwareupdate/memento_updater.sh:150: log "kernel install
dev the same as install dev! (${KINSTALL_DEV})"
On 2010/04/09 16:15:22, sosa wrote:
> Can you be a little more specific here and just say partition rather than
> device?  Easier to read the log and matches with the comments

Done.

http://codereview.chromium.org/1520028/diff/1/5
File src/platform/memento_softwareupdate/split_write.cc (right):

http://codereview.chromium.org/1520028/diff/1/5#newcode104
src/platform/memento_softwareupdate/split_write.cc:104: exit(0);
On 2010/04/09 16:15:22, sosa wrote:
> exit 0 vs exit 1?  Ok to specify more size for the first file than exists in
> stdin?

It's okay if the first partition isn't fully filled by the file if that matches
w/ the size given at the head of the file. fixed.

http://codereview.chromium.org/1520028/diff/1/5#newcode115
src/platform/memento_softwareupdate/split_write.cc:115: close(fd1);
On 2010/04/09 16:15:22, sosa wrote:
> Shouldn't you always close your files ... you seem to prematurely exit a lot
and
> wouldn't call close.  

The OS automatically closes open file descriptors when a process exits, so this
is safe. I added explicit closes, tho.

http://codereview.chromium.org/1520028/diff/1/6
File src/scripts/mk_memento_images.sh (right):

http://codereview.chromium.org/1520028/diff/1/6#newcode13
src/scripts/mk_memento_images.sh:13: if [ -z "$2" -o -z "$1" ]; then
On 2010/04/09 16:15:22, sosa wrote:
> Can you have a -z $1 but not -z $2?  I would think you'd only need to check if
> there's a second argument since that implies there's a first

I guess just incase they pass empty string for $1. E.g., caller does something
like:

mk_memento_images.sh "$SOME_VAR" "$OTHER_VAR"

if SOME_VAR were empty string, this script would get empty string for $1

http://codereview.chromium.org/1520028/diff/1/6#newcode29
src/scripts/mk_memento_images.sh:29: echo "Kernel partition size ($KPART_SIZE
bytes) greater than 16 MiB."
On 2010/04/09 16:15:22, sosa wrote:
> MB*

Technically M is a SI prefix that means 1000000. Mi is a newer, and increasingly
adopted, prefix that means (1024 * 1024).

[sosa, 2010-04-09 19:50:57]

lgtm