Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 1519027: Make VM state tracking to be independent of logging and profiling. (Closed)

Created:
10 years, 8 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make VM state tracking to be independent of logging and profiling. Also pull out VMState into its own set of source files. Committed: http://code.google.com/p/v8/source/detail?r=4361

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -135 lines) Patch
M SConstruct View 2 chunks +17 lines, -1 line 0 comments Download
M src/SConscript View 1 chunk +1 line, -0 lines 0 comments Download
M src/api.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/log.h View 3 chunks +0 lines, -34 lines 0 comments Download
M src/log.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M src/log-inl.h View 2 chunks +2 lines, -89 lines 0 comments Download
M src/platform-freebsd.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-macos.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-openbsd.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-solaris.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/platform-win32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/spaces.h View 2 chunks +12 lines, -0 lines 0 comments Download
M src/v8.h View 1 chunk +1 line, -0 lines 0 comments Download
A src/vm-state.h View 1 chunk +70 lines, -0 lines 0 comments Download
A src/vm-state.cc View 1 chunk +39 lines, -0 lines 0 comments Download
A src/vm-state-inl.h View 1 chunk +134 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/v8.xcodeproj/project.pbxproj View 5 chunks +10 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_base.vcproj View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_base_arm.vcproj View 1 chunk +12 lines, -0 lines 0 comments Download
M tools/visual_studio/v8_base_x64.vcproj View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
10 years, 8 months ago (2010-04-08 09:39:25 UTC) #1
Mads Ager (chromium)
10 years, 8 months ago (2010-04-08 12:54:33 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698