Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1518013: Don't forcibly set our network state to NETWORK_LOADING after media initializes. (Closed)

Created:
10 years, 8 months ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, scherkus (not reviewing), fbarchard, darin-cc_chromium.org, awong
Visibility:
Public.

Description

Don't forcibly set our network state to NETWORK_LOADING after media initializes. We already set the network state to NETWORK_LOADING before we kick off initialization. Furthermore, we may end up caching the entire media resource and set our network state to NETWORK_IDLE in which case we really don't want to switch back to NETWORK_LOADING. BUG=25185 TEST=covered by layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43441

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M webkit/glue/webmediaplayer_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scherkus (not reviewing)
This fixes another subtle bug where we'll accidentally return to NETWORK_LOADING if we've downloaded the ...
10 years, 8 months ago (2010-04-02 02:31:26 UTC) #1
Alpha Left Google
10 years, 8 months ago (2010-04-02 02:37:14 UTC) #2
On 2010/04/02 02:31:26, scherkus wrote:
> This fixes another subtle bug where we'll accidentally return to
NETWORK_LOADING
> if we've downloaded the entire file before even starting to play

LGTM

Powered by Google App Engine
This is Rietveld 408576698