Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: webkit/glue/webmediaplayer_impl.cc

Issue 1518013: Don't forcibly set our network state to NETWORK_LOADING after media initializes. (Closed)
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webmediaplayer_impl.cc
diff --git a/webkit/glue/webmediaplayer_impl.cc b/webkit/glue/webmediaplayer_impl.cc
index c85d6d0f5c817960f049eafae1d4de0f4947c564..41c76f7137779280d0be0e07bc1f5465440a670a 100644
--- a/webkit/glue/webmediaplayer_impl.cc
+++ b/webkit/glue/webmediaplayer_impl.cc
@@ -575,14 +575,13 @@ void WebMediaPlayerImpl::OnPipelineInitialize() {
static_cast<float>(pipeline_->GetDuration().InSecondsF());
buffered_.swap(new_buffered);
- // Since we have initialized the pipeline, say we have everything.
+ // Since we have initialized the pipeline, say we have everything otherwise
+ // we'll remain either loading/idle.
// TODO(hclam): change this to report the correct status.
SetReadyState(WebKit::WebMediaPlayer::HaveMetadata);
SetReadyState(WebKit::WebMediaPlayer::HaveEnoughData);
if (pipeline_->IsLoaded()) {
SetNetworkState(WebKit::WebMediaPlayer::Loaded);
- } else {
- SetNetworkState(WebKit::WebMediaPlayer::Loading);
}
} else {
// TODO(hclam): should use pipeline_->GetError() to determine the state
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698