Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 1515011: Adds gmergefs. A method of remoting to a target and pushing new (Closed)

Created:
10 years, 8 months ago by sosa
Modified:
10 years, 8 months ago
Reviewers:
rtc, tedbo, adlr
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Adds gmergefs. A method of remoting to a target and pushing new packages using emerge from the host

Patch Set 1 #

Patch Set 2 : Add setup #

Patch Set 3 : Clean up #

Total comments: 4

Patch Set 4 : Fixes for adlr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -13 lines) Patch
A src/platform/dev/gmergefs View 1 2 3 1 chunk +132 lines, -0 lines 0 comments Download
M src/scripts/build_image View 1 chunk +2 lines, -2 lines 0 comments Download
M src/scripts/common.sh View 1 2 3 2 chunks +28 lines, -0 lines 0 comments Download
M src/scripts/enter_chroot.sh View 2 3 3 chunks +27 lines, -2 lines 0 comments Download
M src/scripts/run_remote_tests.sh View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sosa
Adds gmergefs to platform/dev To use gmergefs --remote ip_addr package This takes many of the ...
10 years, 8 months ago (2010-04-01 00:34:33 UTC) #1
Sam Leffler
How is this different from running gmerge on the target? Does it not require a ...
10 years, 8 months ago (2010-04-01 01:16:30 UTC) #2
sosa
It's another approach to doing it that takes advantage of the build system on the ...
10 years, 8 months ago (2010-04-01 01:29:55 UTC) #3
sosa
To follow-up this approach has three requirements: 1) Fuse is installed on development machine 2) ...
10 years, 8 months ago (2010-04-01 01:32:32 UTC) #4
sosa
Looks like tedbo is out of town and rtc is busy. Can you take a ...
10 years, 8 months ago (2010-04-02 18:31:49 UTC) #5
adlr
http://codereview.chromium.org/1515011/diff/5001/6001 File src/platform/dev/gmergefs (right): http://codereview.chromium.org/1515011/diff/5001/6001#newcode72 src/platform/dev/gmergefs:72: [[ $FLAGS_installmask -eq $FLAGS_TRUE ]] && INSTALL_MASK="/usr/include/ /usr/man /usr/share/man ...
10 years, 8 months ago (2010-04-02 19:12:34 UTC) #6
adlr
10 years, 8 months ago (2010-04-02 19:21:05 UTC) #7
LGTM if you address the comments

On Fri, Apr 2, 2010 at 12:12 PM, <adlr@chromium.org> wrote:

>
> http://codereview.chromium.org/1515011/diff/5001/6001
> File src/platform/dev/gmergefs (right):
>
> http://codereview.chromium.org/1515011/diff/5001/6001#newcode72
> src/platform/dev/gmergefs:72: [[ $FLAGS_installmask -eq $FLAGS_TRUE ]]
> && INSTALL_MASK="/usr/include/ /usr/man /usr/share/man /usr/share/doc
> /usr/share/gtk-doc /usr/share/gtk-2.0 /usr/lib/gtk-2.0/include
> /usr/share/info /usr/share/aclocal /usr/lib/gcc /usr/lib/pkgconfig
> /usr/share/pkgconfig /usr/share/gettext /usr/share/readline
> /etc/runlevels /usr/share/openrc /lib/rc *.a *.la"
> 80 cols
>
> http://codereview.chromium.org/1515011/diff/5001/6001#newcode75
> src/platform/dev/gmergefs:75: [[ $FLAGS_jobs -ne -1 ]]  &&
> EMERGE_JOBS="--jobs=$FLAGS_jobs"
> ditch extra space before &&
>
> http://codereview.chromium.org/1515011/diff/5001/6001#newcode85
> src/platform/dev/gmergefs:85: # Setup sshfs remote mount on target
> machine
> does this comment reference anything?
>
> http://codereview.chromium.org/1515011/diff/5001/6003
> File src/scripts/enter_chroot.sh (right):
>
> http://codereview.chromium.org/1515011/diff/5001/6003#newcode147
> src/scripts/enter_chroot.sh:147: INNER_MOD_PATH="$(readlink -f
> "${FLAGS_chroot}${KERNEL_MODULES_ROOT}")"
> 80 cols
>
>
> http://codereview.chromium.org/1515011
>

Powered by Google App Engine
This is Rietveld 408576698