Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1513019: Create EFI System Partition on USB image during build. (Closed)

Created:
10 years, 8 months ago by Bill Richardson
Modified:
9 years, 6 months ago
Reviewers:
Randall Spangler, adlr, sosa
CC:
chromium-os-reviews_chromium.org, adlr
Visibility:
Public.

Description

Create EFI System Partition on USB image during build. The EFI System Partition is a special disk partition where EFI BIOS expects to find the platform-specific bootloader. We need this in order to work on the BIOS/kernel handoff. It's not needed for the final ChromeOS image and it isn't useful for legacy BIOS systems, so right now it only makes any difference on x86 devices with development BIOSes. This change creates the partition for ARM builds as well; it has no effect there, either.

Patch Set 1 #

Total comments: 3

Patch Set 2 : Cleanup, add image_to_vmware.sh changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -32 lines) Patch
M src/platform/installer/chromeos-common.sh View 1 8 chunks +28 lines, -14 lines 0 comments Download
M src/platform/installer/chromeos-install View 2 chunks +5 lines, -1 line 0 comments Download
M src/scripts/build_gpt.sh View 5 chunks +13 lines, -4 lines 0 comments Download
M src/scripts/build_image View 1 9 chunks +43 lines, -9 lines 0 comments Download
M src/scripts/image_to_vmware.sh View 5 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Bill Richardson
10 years, 8 months ago (2010-04-06 18:14:07 UTC) #1
Randall Spangler
LGTM http://codereview.chromium.org/1513019/diff/1/2 File src/platform/installer/chromeos-common.sh (right): http://codereview.chromium.org/1513019/diff/1/2#newcode266 src/platform/installer/chromeos-common.sh:266: # and the ESP partition and --> add ...
10 years, 8 months ago (2010-04-06 19:56:02 UTC) #2
sosa
LGTM http://codereview.chromium.org/1513019/diff/1/5 File src/scripts/build_image (right): http://codereview.chromium.org/1513019/diff/1/5#newcode337 src/scripts/build_image:337: # Create EFI System Partition to boot stock ...
10 years, 8 months ago (2010-04-06 20:01:21 UTC) #3
adlr
can you update image_to_vmware.sh also? And grep to see if anything else is calling install_gpt
10 years, 8 months ago (2010-04-06 20:03:00 UTC) #4
Bill Richardson
10 years, 8 months ago (2010-04-06 21:23:09 UTC) #5
adlr
10 years, 8 months ago (2010-04-06 21:52:17 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698