autotest ebuild change.

autotest ebuild change.

This ebuild file has been refactored to support prebuild functions inside autoserv. and should be reviewed with:

http://codereview.chromium.org/1317002
http://codereview.chromium.org/1595001

It also provides backward compatibility functions to build all client tests without executing them.

[adlr, 2010-03-30 22:16:23]

http://codereview.chromium.org/1513006/diff/4001/5001
File chromeos-base/autotest/autotest-0.0.1.ebuild (right):

http://codereview.chromium.org/1513006/diff/4001/5001#newcode74
chromeos-base/autotest/autotest-0.0.1.ebuild:74: cp -fpru
${autotest_files}/{client,conmux,server,tko,utils} ${dst} || die
quotes around ${autotest_files}

http://codereview.chromium.org/1513006/diff/4001/5001#newcode81
chromeos-base/autotest/autotest-0.0.1.ebuild:81: cd ${S}
quotes around ${S}

http://codereview.chromium.org/1513006/diff/4001/5001#newcode115
chromeos-base/autotest/autotest-0.0.1.ebuild:115: cd ${BUILD_STAGE}
quotes around ${BUILD_STAGE}

[ericli, 2010-03-30 22:30:30]

fixed. PTAL.

http://codereview.chromium.org/1513006/diff/4001/5001
File chromeos-base/autotest/autotest-0.0.1.ebuild (right):

http://codereview.chromium.org/1513006/diff/4001/5001#newcode74
chromeos-base/autotest/autotest-0.0.1.ebuild:74: cp -fpru
${autotest_files}/{client,conmux,server,tko,utils} ${dst} || die
On 2010/03/30 22:16:23, adlr wrote:
> quotes around ${autotest_files}

Done.

http://codereview.chromium.org/1513006/diff/4001/5001#newcode81
chromeos-base/autotest/autotest-0.0.1.ebuild:81: cd ${S}
On 2010/03/30 22:16:23, adlr wrote:
> quotes around ${S}

Done.

http://codereview.chromium.org/1513006/diff/4001/5001#newcode115
chromeos-base/autotest/autotest-0.0.1.ebuild:115: cd ${BUILD_STAGE}
On 2010/03/30 22:16:23, adlr wrote:
> quotes around ${BUILD_STAGE}

Done.

[adlr, 2010-03-30 22:40:15]

LGTM

On Tue, Mar 30, 2010 at 3:30 PM, <ericli@chromium.org> wrote:

> fixed. PTAL.
>
>
>
>
> http://codereview.chromium.org/1513006/diff/4001/5001
> File chromeos-base/autotest/autotest-0.0.1.ebuild (right):
>
> http://codereview.chromium.org/1513006/diff/4001/5001#newcode74
> chromeos-base/autotest/autotest-0.0.1.ebuild:74: cp -fpru
> ${autotest_files}/{client,conmux,server,tko,utils} ${dst} || die
> On 2010/03/30 22:16:23, adlr wrote:
>
>> quotes around ${autotest_files}
>>
>
> Done.
>
>
> http://codereview.chromium.org/1513006/diff/4001/5001#newcode81
> chromeos-base/autotest/autotest-0.0.1.ebuild:81: cd ${S}
> On 2010/03/30 22:16:23, adlr wrote:
>
>> quotes around ${S}
>>
>
> Done.
>
>
> http://codereview.chromium.org/1513006/diff/4001/5001#newcode115
> chromeos-base/autotest/autotest-0.0.1.ebuild:115: cd ${BUILD_STAGE}
> On 2010/03/30 22:16:23, adlr wrote:
>
>> quotes around ${BUILD_STAGE}
>>
>
> Done.
>
>
> http://codereview.chromium.org/1513006
>

[sosa, 2010-03-30 22:58:14]

http://codereview.chromium.org/1513006/diff/9001/10001
File chromeos-base/autotest/autotest-0.0.1.ebuild (right):

http://codereview.chromium.org/1513006/diff/9001/10001#newcode28
chromeos-base/autotest/autotest-0.0.1.ebuild:28:
BUILD_STAGE=${PORTAGE_BUILDDIR}/staging
Comment to explain what build_stage is

http://codereview.chromium.org/1513006/diff/9001/10001#newcode48
chromeos-base/autotest/autotest-0.0.1.ebuild:48:
SSH_KEY=${CHROMEOS_ROOT}/src/scripts/mod_for_test_scripts/ssh_keys/testing_rsa
too long

http://codereview.chromium.org/1513006/diff/9001/10001#newcode56
chromeos-base/autotest/autotest-0.0.1.ebuild:56: function setup_x_toolchain() {
Rename from x to something else.  X is overloaded on Chrome OS between X Server
and Cross.

http://codereview.chromium.org/1513006/diff/9001/10001#newcode74
chromeos-base/autotest/autotest-0.0.1.ebuild:74: cp -fpru
"${autotest_files}"/{client,conmux,server,tko,utils} ${dst} || die
too long

http://codereview.chromium.org/1513006/diff/9001/10001#newcode75
chromeos-base/autotest/autotest-0.0.1.ebuild:75: cp -fpru
"${autotest_files}"/{global_config.ini,shadow_config.ini} ${dst} \
too long

http://codereview.chromium.org/1513006/diff/9001/10001#newcode94
chromeos-base/autotest/autotest-0.0.1.ebuild:94: client/bin/autotest_client
--quiet --client_test_setup=${TEST_LIST} \
too long

http://codereview.chromium.org/1513006/diff/9001/10001#newcode119
chromeos-base/autotest/autotest-0.0.1.ebuild:119: TIMESTAMP=$(date
+%Y-%m-%d-%H.%M.%S)
Why not local?

[ericli, 2010-03-30 23:13:08]

PTAL.

The line looks too long on the web because codereview web rendered TAB into 8
chars space.

They are well within 80 chars. If we count TAB as 1, 2 or 4 chars.

Eric
On 2010/03/30 22:58:14, sosa wrote:
> http://codereview.chromium.org/1513006/diff/9001/10001
> File chromeos-base/autotest/autotest-0.0.1.ebuild (right):
> 
> http://codereview.chromium.org/1513006/diff/9001/10001#newcode28
> chromeos-base/autotest/autotest-0.0.1.ebuild:28:
> BUILD_STAGE=${PORTAGE_BUILDDIR}/staging
> Comment to explain what build_stage is
> 
> http://codereview.chromium.org/1513006/diff/9001/10001#newcode48
> chromeos-base/autotest/autotest-0.0.1.ebuild:48:
> SSH_KEY=${CHROMEOS_ROOT}/src/scripts/mod_for_test_scripts/ssh_keys/testing_rsa
> too long
> 
> http://codereview.chromium.org/1513006/diff/9001/10001#newcode56
> chromeos-base/autotest/autotest-0.0.1.ebuild:56: function setup_x_toolchain()
{
> Rename from x to something else.  X is overloaded on Chrome OS between X
Server
> and Cross.
> 
> http://codereview.chromium.org/1513006/diff/9001/10001#newcode74
> chromeos-base/autotest/autotest-0.0.1.ebuild:74: cp -fpru
> "${autotest_files}"/{client,conmux,server,tko,utils} ${dst} || die
> too long
> 
> http://codereview.chromium.org/1513006/diff/9001/10001#newcode75
> chromeos-base/autotest/autotest-0.0.1.ebuild:75: cp -fpru
> "${autotest_files}"/{global_config.ini,shadow_config.ini} ${dst} \
> too long
> 
> http://codereview.chromium.org/1513006/diff/9001/10001#newcode94
> chromeos-base/autotest/autotest-0.0.1.ebuild:94: client/bin/autotest_client
> --quiet --client_test_setup=${TEST_LIST} \
> too long
> 
> http://codereview.chromium.org/1513006/diff/9001/10001#newcode119
> chromeos-base/autotest/autotest-0.0.1.ebuild:119: TIMESTAMP=$(date
> +%Y-%m-%d-%H.%M.%S)
> Why not local?

[sosa, 2010-03-30 23:15:27]

lgtm, thnx