Issue 151202: Remove sysctl-read workarounds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151202: Remove sysctl-read workarounds (Closed)

Created:
11 years, 5 months ago by jeremy

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai, pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com, John Grabowski

Visibility:
Public.

Description

We recently enabled reading sysctl values from inside the sandbox. This CL removes workarounds needed when sysctl reads where blocked.

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -42 lines)			Patch
M	base/sys_info.h	View	3 chunks	+0 lines, -12 lines	0 comments	Download
M	base/sys_info_mac.cc	View	1 chunk	+11 lines, -25 lines	1 comment	Download
M	base/sys_info_posix.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/renderer_main_platform_delegate_mac.mm	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 5 months ago (2009-07-02 14:58:06 UTC) #3

Hooray for code reduction!

http://codereview.chromium.org/151202/diff/1/3
File base/sys_info_mac.cc (right):

http://codereview.chromium.org/151202/diff/1/3#newcode15
Line 15: int32 major_version_cached = 0;
These shouldn't be called whatever_cached anymore.

In fact, you should just do away with these local variables.  You can use the
parameters directly (with the SInt32* cast) in the Gestalt calls.

Expand Messages | Collapse Messages