Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: base/sys_info.h

Issue 151202: Remove sysctl-read workarounds (Closed)
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/sys_info_mac.cc » ('j') | base/sys_info_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/sys_info.h
diff --git a/base/sys_info.h b/base/sys_info.h
index 16b86903920274a177c531b8dfc146e309236e0a..d083377026a9c9f34c562ab6543f2a6b12a724d1 100644
--- a/base/sys_info.h
+++ b/base/sys_info.h
@@ -14,8 +14,6 @@ namespace base {
class SysInfo {
public:
// Return the number of logical processors/cores on the current machine.
- // WARNING: On POSIX, this method uses static variables and is not threadsafe
- // until it's been initialized by being called once without a race.
static int NumberOfProcessors();
// Return the number of bytes of physical memory on the current machine.
@@ -46,8 +44,6 @@ class SysInfo {
static std::string OperatingSystemVersion();
// Retrieves detailed numeric values for the OS version.
- // WARNING: On OS X, this method uses static variables and is not threadsafe
- // until it's been initialized by being called once without a race.
// TODO(port): Implement a Linux version of this method and enable the
// corresponding unit test.
static void OperatingSystemVersionNumbers(int32 *major_version,
@@ -68,14 +64,6 @@ class SysInfo {
// Return the smallest amount of memory (in bytes) which the VM system will
// allocate.
static size_t VMAllocationGranularity();
-
-#if defined(OS_MACOSX)
- // Under the OS X Sandbox, our access to the system is limited, this call
- // caches the system info on startup before we turn the Sandbox on.
- // The above functions are all wired up to return the cached value so the rest
- // of the code can call them in the Sandbox without worrying.
- static void CacheSysInfo();
-#endif
};
} // namespace base
« no previous file with comments | « no previous file | base/sys_info_mac.cc » ('j') | base/sys_info_mac.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698