Issue 151144: ARM: Don't always go into the runtime system just because a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151144: ARM: Don't always go into the runtime system just because a (Closed)

Created:
11 years, 5 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Don't always go into the runtime system just because a mul gave zero. Committed: http://code.google.com/p/v8/source/detail?r=2318

Patch Set 1 #

Total comments: 2

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	src/arm/codegen-arm.cc	View		1 chunk	+7 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/151144/diff/1/2 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/151144/diff/1/2#newcode5340 Line 5340: __ mov(r0, Operand(Smi::FromInt(0)), LeaveCC, pl); Is it ...

11 years, 5 months ago (2009-07-01 11:11:13 UTC) #2

Erik Corry

11 years, 5 months ago (2009-07-01 11:31:05 UTC) #3

http://codereview.chromium.org/151144/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/151144/diff/1/2#newcode5340
Line 5340: __ mov(r0, Operand(Smi::FromInt(0)), LeaveCC, pl);
On 2009/07/01 11:11:14, Lasse Reichstein wrote:
> Is it more efficient to use r3 instead of Operand(Smi::FromInt(0))? (We should
> know that r3 is zero at this point).

I'm fairly certain it makes no difference, so I think I'll stick with the less
sneaky version.

Expand Messages | Collapse Messages