Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/cocoa/browser_window_controller.mm

Issue 151107: Mac valgrind fix (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/valgrind/suppressions_mac.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/browser_window_controller.mm
===================================================================
--- chrome/browser/cocoa/browser_window_controller.mm (revision 19559)
+++ chrome/browser/cocoa/browser_window_controller.mm (working copy)
@@ -657,8 +657,16 @@
[content removeFromSuperview];
[window_ setContentView:content];
[self setWindow:window_.get()];
+ [content setNeedsDisplay:YES];
+
+ // With this call, valgrind yells at me about "Conditional jump or
+ // move depends on uninitialised value(s)". The error happens in
+ // -[NSThemeFrame drawOverlayRect:]. I'm pretty convinced this is
+ // an Apple bug, but there is no visual impact. I have been
+ // unable to tickle it away with other window or view manipulation
+ // Cocoa calls. Stack added to suppressions_mac.txt.
[window_ makeKeyAndOrderFront:self];
- [content setNeedsDisplay:YES];
+
[fullscreen_window_ close];
fullscreen_window_.reset(nil);
}
« no previous file with comments | « no previous file | tools/valgrind/suppressions_mac.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698