Mac valgrind fix

chrome/browser/cocoa/browser_window_controller.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <Carbon/Carbon.h>
 
 #include "base/mac_util.h"
 #include "base/scoped_nsdisable_screen_updates.h"
 #include "base/sys_string_conversions.h"
 #include "chrome/app/chrome_dll_resource.h"  // IDC_*
@@ skipping 639 matching lines @@
     // Show one window, hide the other.
     [fullscreen_window_ makeKeyAndOrderFront:self];
     [content setNeedsDisplay:YES];
     [window_ orderOut:self];
   } else {
     [self adjustUIForFullscreen:fullscreen];
     NSView* content = [fullscreen_window_ contentView];
     [content removeFromSuperview];
     [window_ setContentView:content];
     [self setWindow:window_.get()];
+    [content setNeedsDisplay:YES];
+
+    // With this call, valgrind yells at me about "Conditional jump or
+    // move depends on uninitialised value(s)".  The error happens in
+    // -[NSThemeFrame drawOverlayRect:].  I'm pretty convinced this is
+    // an Apple bug, but there is no visual impact.  I have been
+    // unable to tickle it away with other window or view manipulation
+    // Cocoa calls.  Stack added to suppressions_mac.txt.
     [window_ makeKeyAndOrderFront:self];
-    [content setNeedsDisplay:YES];
+
     [fullscreen_window_ close];
     fullscreen_window_.reset(nil);
   }
 }
 
 - (BOOL)isFullscreen {
   return fullscreen_;
 }
 
 // Called by the bookmark bar to open a URL.
@@ skipping 213 matching lines @@
     browser_->ExecuteCommand(command);
 }
 
 - (id)windowWillReturnFieldEditor:(NSWindow*)sender toObject:(id)obj {
   // Ask the toolbar controller if it wants to return a custom field editor
   // for the specific object.
   return [toolbarController_ customFieldEditorForObject:obj];
 }
 
 @end