Issue 151107: Mac valgrind fix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151107: Mac valgrind fix (Closed)

Created:
11 years, 5 months ago by John Grabowski

Modified:
9 years, 6 months ago

Reviewers:
Avi (use Gerrit), pink (ping after 24hrs), dank

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google), Nirnimesh, Glen Murphy

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -1 line)			Patch
	M	chrome/browser/cocoa/browser_window_controller.mm	View		1 chunk	+9 lines, -1 line	0 comments	Download
	M	tools/valgrind/suppressions_mac.txt	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

John Grabowski

cc: avi in case he has ideas about Cocoa things to try.

11 years, 5 months ago (2009-06-30 20:44:13 UTC) #1

dank

If possible, file a rdar bug for this and use that in the name of ...

11 years, 5 months ago (2009-06-30 20:50:38 UTC) #2

Avi (use Gerrit)

Kinda weird, but can't think of anything better to do. We need to start filing ...

11 years, 5 months ago (2009-06-30 20:51:35 UTC) #3

LGTM