Issue 151103: Changed way Packs cannot be created if there is no Renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151103: Changed way Packs cannot be created if there is no Renderer. (Closed)

Created:
11 years, 5 months ago by apatrick

Modified:
9 years, 7 months ago

Reviewers:
gman1

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Description

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19663

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -20 lines)			Patch
M	core/cross/client.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	core/cross/client.cc	View	2 chunks	+10 lines, -4 lines	1 comment	Download
M	core/cross/object_manager.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	core/cross/object_manager.cc	View	3 chunks	+1 line, -10 lines	0 comments	Download
M	core/cross/pack.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

gman

11 years, 5 months ago (2009-06-30 21:32:11 UTC) #2

LGTM

http://codereview.chromium.org/151103/diff/1/2
File core/cross/client.cc (right):

http://codereview.chromium.org/151103/diff/1/2#newcode146
Line 146: O3D_ERROR(service_locator_) << "Pack creation not allowed";
How about changing this message to "No Renderer available, Pack creation not
allowed." or something like that? People get the message now and they have no
idea what went wrong or where to start looking.

Expand Messages | Collapse Messages