Changed way Packs cannot be created if there is no Renderer.

core/cross/client.cc

 /*
  * Copyright 2009, Google Inc.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 98 matching lines @@
 
   // Unmap the client from the renderer on exit.
   if (renderer_.IsAvailable()) {
     renderer_->UninitCommon();
   }
 }
 
 // Assigns a Renderer to the Client, and also assigns the Client
 // to the Renderer and sets up the default render graph
 void Client::Init() {
-  if (!renderer_.IsAvailable()) {
-    // Don't allow packs to be created.
-    object_manager_->DisallowPackCreation();
+  if (!renderer_.IsAvailable())
     return;
-  }
 
   // Create the root node for the scenegraph.  Note that the root lives
   // outside of a pack object.  The root's lifetime is directly bound to that
   // of the client.
   root_ = Transform::Ref(new Transform(service_locator_));
   root_->set_name(O3D_STRING_CONSTANT("root"));
 
   // Creates the root for the render graph.
   rendergraph_root_ = RenderNode::Ref(new RenderNode(service_locator_));
   rendergraph_root_->set_name(O3D_STRING_CONSTANT("root"));
 
   // Let the renderer Init a few common things.
   renderer_->InitCommon();
 }
 
 void Client::Cleanup() {
   ClearRenderCallback();
   ClearPostRenderCallback();
   ClearTickCallback();
   event_manager_.ClearAll();
   counter_manager_.ClearAllCallbacks();
 }
 
+Pack* Client::CreatePack() {
+  if (!renderer_.IsAvailable()) {
+    O3D_ERROR(service_locator_) << "Pack creation not allowed";

[gman, 2009/06/30 21:32:11]

How about changing this message to "No Renderer available, Pack creation not
allowed." or something like that? People get the message now and they have no
idea what went wrong or where to start looking.

+    return NULL;
+  }
+
+  return object_manager_->CreatePack();
+}
+
 // Tick Methods ----------------------------------------------------------------
 
 void Client::SetTickCallback(
     TickCallback* tick_callback) {
   tick_callback_manager_.Set(tick_callback);
 }
 
 void Client::ClearTickCallback() {
   tick_callback_manager_.Clear();
 }
@@ skipping 280 matching lines @@
 }
 
 String Client::ProfileToString() {
   StringWriter string_writer(StringWriter::LF);
   JsonWriter json_writer(&string_writer, 2);
   profiler_->Write(&json_writer);
   json_writer.Close();
   return string_writer.ToString();
 }
 }  // namespace o3d