Issue 151003: Add a compare stub on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151003: Add a compare stub on ARM. (Closed)

Created:
11 years, 6 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add a compare stub on ARM. Committed: http://code.google.com/p/v8/source/detail?r=2295

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+589 lines, -108 lines)			Patch
M	src/arm/codegen-arm.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	src/arm/codegen-arm.cc	View	1	13 chunks	+454 lines, -53 lines	0 comments	Download
M	src/arm/simulator-arm.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/assembler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/assembler.cc	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	src/codegen.h	View		1 chunk	+30 lines, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View		2 chunks	+6 lines, -34 lines	0 comments	Download
M	src/serialize.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	test/mjsunit/compare-nan.js	View		1 chunk	+12 lines, -12 lines	0 comments	Download
M	test/mjsunit/html-comments.js	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	test/mjsunit/smi-ops.js	View		1 chunk	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM if you make sure you have good coverage of the generated code. http://codereview.chromium.org/151003/diff/1/4 File ...

11 years, 5 months ago (2009-06-29 06:13:52 UTC) #2

Erik Corry

11 years, 5 months ago (2009-06-29 13:42:29 UTC) #3

More tests added to boost coverage.

http://codereview.chromium.org/151003/diff/1/4
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/151003/diff/1/4#newcode7822
Line 7822: int CompareStub::MinorKey() {
On 2009/06/29 06:13:52, Kasper Lund wrote:
> Couldn't this go into codegen.cc?

On ARM the condition codes are in bits 28-31 so they have to be shifted down. 
On Intel the condition codes are already in the low bits.

Expand Messages | Collapse Messages