Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1349)

Unified Diff: chrome/installer/mini_installer/mini_installer.scons

Issue 15051: Convert from using env['PLATFORM'] directly to using the more flexible... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/mini_installer/installer_unittests.scons ('k') | chrome/installer/setup/setup.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mini_installer/mini_installer.scons
===================================================================
--- chrome/installer/mini_installer/mini_installer.scons (revision 7247)
+++ chrome/installer/mini_installer/mini_installer.scons (working copy)
@@ -12,11 +12,11 @@
# TODO(port): Don't be too fooled by the presence of all the
-# if env['PLATFORM'] == 'win32' tests in this file into thinking
+# if env.Bit('windows') tests in this file into thinking
# this is necessarily portable. They're just there to wall off the
# obviously windows-specific things
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
env_res = env.Clone()
env_res.Append(
@@ -42,7 +42,7 @@
],
)
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
env.FilterOut(
LIBS = ['DelayImp.lib'],
CCFLAGS = ['/RTC1'],
@@ -80,7 +80,7 @@
"pe_resource.cc",
]
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
input_files.extend([
"$VISUAL_STUDIO/VC/crt/src/intel/mt_lib/memset.obj",
"$VISUAL_STUDIO/VC/crt/src/intel/mt_lib/P4_memset.obj",
@@ -109,6 +109,6 @@
'mini_installer_exe_version.rc.version',
PWD=Dir('.'))
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
# TODO(sgk): implicit dependency should be picked up automatically
env_res.Depends(resources, exe_version_rc)
« no previous file with comments | « chrome/installer/mini_installer/installer_unittests.scons ('k') | chrome/installer/setup/setup.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698