Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: chrome/installer/setup/setup.scons

Issue 15051: Convert from using env['PLATFORM'] directly to using the more flexible... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/mini_installer/mini_installer.scons ('k') | chrome/plugin/plugin.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/setup.scons
===================================================================
--- chrome/installer/setup/setup.scons (revision 7247)
+++ chrome/installer/setup/setup.scons (working copy)
@@ -13,7 +13,7 @@
'$LZMA_SDK_DIR/using_lzma_sdk.scons',
])
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
env_res = env.Clone()
env_res.Append(
@@ -46,7 +46,7 @@
],
)
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
env.Prepend(
LINKFLAGS = [
'/INCREMENTAL',
@@ -87,6 +87,6 @@
'setup_exe_version.rc.version',
PWD = env.Dir('.'))
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
# TODO(sgk): implicit dependency should be picked up automatically
env_res.Depends(resources, exe_version_rc)
« no previous file with comments | « chrome/installer/mini_installer/mini_installer.scons ('k') | chrome/plugin/plugin.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698