Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4051)

Unified Diff: base/base_unittests.scons

Issue 15051: Convert from using env['PLATFORM'] directly to using the more flexible... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/base_lib.scons ('k') | base/gfx/base_gfx.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base_unittests.scons
===================================================================
--- base/base_unittests.scons (revision 7247)
+++ base/base_unittests.scons (working copy)
@@ -20,12 +20,12 @@
'$ZLIB_DIR/using_zlib.scons',
])
-if env['PLATFORM'] in ('posix', 'darwin'):
+if env.Bit('posix'):
env.ApplySConscript([
'$LIBEVENT_DIR/using_libevent.scons',
])
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
env.Prepend(
CCFLAGS = [
'/TP',
@@ -33,7 +33,7 @@
],
)
-if env['PLATFORM'] == 'posix':
+if env.Bit('linux'):
env.Append(
# We need 'Xss' (X Screen Saver) in LIBS if we want idletimer_unittest
LIBS = [
@@ -99,7 +99,7 @@
'gfx/rect_unittest.cc',
]
-if env['PLATFORM'] in ('posix', 'darwin'):
+if env.Bit('posix'):
# Remove files that still need to be ported from the input_files list.
# TODO(port): delete files from this list as they get ported.
to_be_ported_files = [
@@ -112,7 +112,7 @@
for remove in to_be_ported_files:
input_files.remove(remove)
-if env['PLATFORM'] == 'darwin':
+if env.Bit('mac'):
# Remove files that still need to be ported from the input_files list.
# TODO(port): delete files from this list as they get ported.
to_be_ported_files = [
@@ -123,7 +123,7 @@
input_files.remove(remove)
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
# Windows-specific tests.
input_files.extend([
'directory_watcher_unittest.cc',
@@ -136,7 +136,7 @@
'wmi_util_unittest.cc',
])
-if env['PLATFORM'] == 'darwin':
+if env.Bit('mac'):
# Mac-specific tests.
input_files.extend([
'mac_util_unittest.cc',
« no previous file with comments | « base/base_lib.scons ('k') | base/gfx/base_gfx.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698