Convert from using env['PLATFORM'] directly to using the more flexible...

base/base_unittests.scons

 # Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 __doc__ = """
 Configuration for building base_unittests{,.exe}.
 """
 
 Import('env')
 
 env = env.Clone()
 
 env.ApplySConscript([
     '$BASE_DIR/using_base.scons',
     '$BASE_DIR/gfx/using_base_gfx.scons',
     '$GTEST_DIR/../using_gtest.scons',
     '$ICU38_DIR/using_icu38.scons',
     '$LIBPNG_DIR/using_libpng.scons',
     '$SKIA_DIR/using_skia.scons',
     '$ZLIB_DIR/using_zlib.scons',
 ])
 
-if env['PLATFORM'] in ('posix', 'darwin'):
+if env.Bit('posix'):
   env.ApplySConscript([
       '$LIBEVENT_DIR/using_libevent.scons',
   ])
 
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
   env.Prepend(
       CCFLAGS = [
           '/TP',
           '/WX',
       ],
   )
 
-if env['PLATFORM'] == 'posix':
+if env.Bit('linux'):
   env.Append(
       # We need 'Xss' (X Screen Saver) in LIBS if we want idletimer_unittest
       LIBS = [
           'event',
       ],
   )
 
 # These test files work on *all* platforms; tests that don't work
 # cross-platform live below.
 input_files = [
@@ skipping 45 matching lines @@
     'waitable_event_unittest.cc',
     'watchdog_unittest.cc',
     'word_iterator_unittest.cc',
     'worker_pool_unittest.cc',
      
     'gfx/native_theme_unittest.cc',
     'gfx/png_codec_unittest.cc',
     'gfx/rect_unittest.cc',
 ]
 
-if env['PLATFORM'] in ('posix', 'darwin'):
+if env.Bit('posix'):
   # Remove files that still need to be ported from the input_files list.
   # TODO(port): delete files from this list as they get ported.
   to_be_ported_files = [
       # We have an implementation of idle_timer, but it's unclear if we want it
       # yet, so it's commented out for now.  Leave this 'unported'.
       'idletimer_unittest.cc',
 
       'gfx/native_theme_unittest.cc',
   ]
   for remove in to_be_ported_files:
     input_files.remove(remove)
 
-if env['PLATFORM'] == 'darwin':
+if env.Bit('mac'):
   # Remove files that still need to be ported from the input_files list.
   # TODO(port): delete files from this list as they get ported.
   to_be_ported_files = [
       'process_util_unittest.cc',
       'stats_table_unittest.cc',
   ]
   for remove in to_be_ported_files:
     input_files.remove(remove)
 
 
-if env['PLATFORM'] == 'win32':
+if env.Bit('windows'):
   # Windows-specific tests.
   input_files.extend([
       'directory_watcher_unittest.cc',
       'file_version_info_unittest.cc',
       'object_watcher_unittest.cc',
       'pe_image_unittest.cc',
       'sys_string_conversions_unittest.cc',
       'time_unittest_win.cc',
       'win_util_unittest.cc',
       'wmi_util_unittest.cc',
   ])
 
-if env['PLATFORM'] == 'darwin':
+if env.Bit('mac'):
   # Mac-specific tests.
   input_files.extend([
       'mac_util_unittest.cc',
   ])
 
 env.ChromeTestProgram('base_unittests', input_files)
 
 # TODO(sgk) should this be moved into base.lib like everything else?  This will
 # require updating a bunch of other SConscripts which link directly against
 # this generated object file.
 env.StaticObject('perftimer.cc')
 
 # Since run_all_perftests supplies a main, we cannot have it in base.lib
 env.StaticObject('run_all_perftests.cc')