net/socket/client_socket_pool_base.cc - Issue 150205: Make ConnectJob::ReleaseSocket() return NULL on connection error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/client_socket_pool_base.cc

Issue 150205: Make ConnectJob::ReleaseSocket() return NULL on connection error. (Closed)

Patch Set: Created 11 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/client_socket_pool_base.cc

diff --git a/net/socket/client_socket_pool_base.cc b/net/socket/client_socket_pool_base.cc

index 2a32e4d1fda6ddafc416a49e1198b5979a938d67..0afe53e65ae890619ffc7d769174b0c91fc04369 100644

--- a/net/socket/client_socket_pool_base.cc

+++ b/net/socket/client_socket_pool_base.cc

@@ -307,6 +307,7 @@ void ClientSocketPoolBase::OnConnectJobComplete(int result, ConnectJob* job) {

RemoveConnectJob(job->key_handle());

if (result != OK) {

+ DCHECK(!socket.get());

callback->Run(result); // |group| is not necessarily valid after this.

// |group| may be invalid after the callback, we need to search

// |group_map_| again.

« no previous file with comments | « net/socket/client_socket_pool_base.h ('k') | net/socket/tcp_client_socket_pool.cc » ('j') | no next file with comments »