net/socket/tcp_client_socket_pool.cc - Issue 150205: Make ConnectJob::ReleaseSocket() return NULL on connection error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/tcp_client_socket_pool.cc

Issue 150205: Make ConnectJob::ReleaseSocket() return NULL on connection error. (Closed)

Patch Set: Created 11 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/tcp_client_socket_pool.cc

diff --git a/net/socket/tcp_client_socket_pool.cc b/net/socket/tcp_client_socket_pool.cc

index a5b5595487a2e0475d394f0908576df6c9442086..6b3fd05377cb14c9b528439fb8b6ebba00a704e7 100644

--- a/net/socket/tcp_client_socket_pool.cc

+++ b/net/socket/tcp_client_socket_pool.cc

@@ -114,6 +114,9 @@ int TCPConnectJob::DoTCPConnectComplete(int result) {

base::TimeDelta::FromMilliseconds(1),

base::TimeDelta::FromMinutes(10),

100);

+ } else {

+ // Delete the socket on error.

+ set_socket(NULL);

}

return result;