Issue 150205: Make ConnectJob::ReleaseSocket() return NULL on connection error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150205: Make ConnectJob::ReleaseSocket() return NULL on connection error. (Closed)

Created:
11 years, 5 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make ConnectJob::ReleaseSocket() return NULL on connection error. BUG=none TEST=none

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -1 line)			Patch
M	net/socket/client_socket_pool_base.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/socket/client_socket_pool_base.cc	View	1 chunk	+1 line, -0 lines	1 comment	Download
M	net/socket/tcp_client_socket_pool.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

I agree that it seemed weird for ReleaseSocket() to return non-NULL on error. I've changed ...

11 years, 5 months ago (2009-07-02 03:04:59 UTC) #1

eroman

11 years, 5 months ago (2009-07-02 05:01:13 UTC) #2

lgtm

http://codereview.chromium.org/150205/diff/1/2
File net/socket/client_socket_pool_base.cc (right):

http://codereview.chromium.org/150205/diff/1/2#newcode306
Line 306: scoped_ptr<ClientSocket> socket(job->ReleaseSocket());
I guess this no longer needs to be scoped_ptr.
But fine either way.

Expand Messages | Collapse Messages