Issue 150018: Optimize %IsConstructCall() on IA-32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 150018: Optimize %IsConstructCall() on IA-32. (Closed)

Created:
11 years, 5 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Optimize %IsConstructCall() on IA-32. Committed: http://code.google.com/p/v8/source/detail?r=2290

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -9 lines)			Patch
M	src/arm/codegen-arm.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/codegen.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/date-delay.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/codegen-ia32.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	src/messages.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/regexp-delay.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/string.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/v8natives.js	View		5 chunks	+4 lines, -5 lines	0 comments	Download
M	src/x64/codegen-x64.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View		1 chunk	+7 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 5 months ago (2009-06-29 08:12:26 UTC) #2

LGTM!

http://codereview.chromium.org/150018/diff/17/1026
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/150018/diff/17/1026#newcode3334
Line 3334: Result answer = frame_->CallRuntime(Runtime::kIsConstructCall, 0);
Maybe add a TODO here and also on ARM so we remember to optimize on those
platforms as well?

Expand Messages | Collapse Messages