Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: src/x64/codegen-x64.cc

Issue 150018: Optimize %IsConstructCall() on IA-32. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/codegen-x64.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3311 matching lines...) Expand 10 before | Expand all | Expand 10 after
3322 __ testl(value.reg(), Immediate(kSmiTagMask)); 3322 __ testl(value.reg(), Immediate(kSmiTagMask));
3323 destination()->false_target()->Branch(equal); 3323 destination()->false_target()->Branch(equal);
3324 // It is a heap object - get map. 3324 // It is a heap object - get map.
3325 // Check if the object is a JS array or not. 3325 // Check if the object is a JS array or not.
3326 __ CmpObjectType(value.reg(), JS_ARRAY_TYPE, kScratchRegister); 3326 __ CmpObjectType(value.reg(), JS_ARRAY_TYPE, kScratchRegister);
3327 value.Unuse(); 3327 value.Unuse();
3328 destination()->Split(equal); 3328 destination()->Split(equal);
3329 } 3329 }
3330 3330
3331 3331
3332 void CodeGenerator::GenerateIsConstructCall(ZoneList<Expression*>* args) {
3333 ASSERT(args->length() == 0);
3334 Result answer = frame_->CallRuntime(Runtime::kIsConstructCall, 0);
Mads Ager (chromium) 2009/06/29 08:12:26 Maybe add a TODO here and also on ARM so we rememb
3335 frame_->Push(&answer);
3336 }
3337
3338
3332 void CodeGenerator::GenerateArgumentsLength(ZoneList<Expression*>* args) { 3339 void CodeGenerator::GenerateArgumentsLength(ZoneList<Expression*>* args) {
3333 ASSERT(args->length() == 0); 3340 ASSERT(args->length() == 0);
3334 // ArgumentsAccessStub takes the parameter count as an input argument 3341 // ArgumentsAccessStub takes the parameter count as an input argument
3335 // in register eax. Create a constant result for it. 3342 // in register eax. Create a constant result for it.
3336 Result count(Handle<Smi>(Smi::FromInt(scope_->num_parameters()))); 3343 Result count(Handle<Smi>(Smi::FromInt(scope_->num_parameters())));
3337 // Call the shared stub to get to the arguments.length. 3344 // Call the shared stub to get to the arguments.length.
3338 ArgumentsAccessStub stub(ArgumentsAccessStub::READ_LENGTH); 3345 ArgumentsAccessStub stub(ArgumentsAccessStub::READ_LENGTH);
3339 Result result = frame_->CallStub(&stub, &count); 3346 Result result = frame_->CallStub(&stub, &count);
3340 frame_->Push(&result); 3347 frame_->Push(&result);
3341 } 3348 }
(...skipping 3411 matching lines...) Expand 10 before | Expand all | Expand 10 after
6753 break; 6760 break;
6754 default: 6761 default:
6755 UNREACHABLE(); 6762 UNREACHABLE();
6756 } 6763 }
6757 } 6764 }
6758 6765
6759 6766
6760 #undef __ 6767 #undef __
6761 6768
6762 } } // namespace v8::internal 6769 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/x64/codegen-x64.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698