Issue 149788: Expose access for reading stats counters via the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149788: Expose access for reading stats counters via the... (Closed)

Created:
11 years, 5 months ago by Mike Belshe

Modified:
9 years, 5 months ago

Reviewers:
erikkay, Erik does not do reviews

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Expose access for reading stats counters via the benchmarking extension. This extension is only available (already) when specifying chrome.exe --enable-benchmarking BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21005

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
	M	webkit/extensions/v8/benchmarking_extension.cc	View		4 chunks	+23 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

LGTM hey... one nit here. I think our current style for these extensions has been ...

11 years, 5 months ago (2009-07-17 16:52:48 UTC) #2

mbelshe

11 years, 5 months ago (2009-07-17 21:20:42 UTC) #3

OK - thanks!

On Fri, Jul 17, 2009 at 9:52 AM, <erikkay@chromium.org> wrote:

> LGTM
>
> hey... one nit here.  I think our current style for these extensions has
> been to expose them as chrome.* instead of chromium.*.  I don't think we
> have any other chromium.* APIs out there.
>
>
> http://codereview.chromium.org/149788
>

Expand Messages | Collapse Messages