Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 149742: Hotspot location changed for all cursors to match the icon center.... (Closed)

Created:
11 years, 5 months ago by Philippe Beauchamp
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Hotspot location changed for all cursors to match the icon center. All hotspots were at (0,0) instead of (16,16) BUG=6173

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/resources/pan_east.cur View Binary file 0 comments Download
M webkit/glue/resources/pan_north.cur View Binary file 0 comments Download
M webkit/glue/resources/pan_north_east.cur View Binary file 0 comments Download
M webkit/glue/resources/pan_north_west.cur View Binary file 0 comments Download
M webkit/glue/resources/pan_south.cur View Binary file 0 comments Download
M webkit/glue/resources/pan_south_east.cur View Binary file 0 comments Download
M webkit/glue/resources/pan_south_west.cur View Binary file 0 comments Download
M webkit/glue/resources/pan_west.cur View Binary file 0 comments Download

Messages

Total messages: 10 (0 generated)
Peter Kasting
You need to set reviewers or your issue won't get looked at. I don't know ...
11 years, 5 months ago (2009-07-16 17:37:54 UTC) #1
Peter Kasting
Pinging this since Glen Murphy is probably the right reviewer but I guess this fell ...
11 years, 4 months ago (2009-08-20 23:50:31 UTC) #2
Philippe Beauchamp
I filed the 3x3 pixels offset bug in webkit with a patch. https://bugs.webkit.org/show_bug.cgi?id=28611 I still ...
11 years, 4 months ago (2009-08-21 13:15:43 UTC) #3
Peter Kasting
Note that I'm still not sure pan_icon.png should be made 20x20, rather than panIconSizeLength changed ...
11 years, 4 months ago (2009-08-21 17:37:20 UTC) #4
Peter Kasting
Never mind, I see you did this upstream already.
11 years, 4 months ago (2009-08-21 17:38:25 UTC) #5
Philippe Beauchamp
New patch Updated. Hotspot changed for all 8 cursors. pan_icon.png removed from list because the ...
11 years, 4 months ago (2009-08-22 20:23:30 UTC) #6
Peter Kasting
OK, let's give this a shot; LGTM. Have you already signed the Committer License Agreement?
11 years, 4 months ago (2009-08-22 22:46:15 UTC) #7
Philippe Beauchamp
Yes On 8/22/09, pkasting@chromium.org <pkasting@chromium.org> wrote: > OK, let's give this a shot; LGTM. Have ...
11 years, 4 months ago (2009-08-23 01:05:30 UTC) #8
Peter Kasting
Well darn. I went to apply this and found that gcl/rietveld don't give me a ...
11 years, 4 months ago (2009-08-24 21:04:35 UTC) #9
Peter Kasting
11 years, 4 months ago (2009-08-25 00:27:47 UTC) #10
Landed in r24192.

Powered by Google App Engine
This is Rietveld 408576698