You need to set reviewers or your issue won't get looked at. I don't know ...
11 years, 5 months ago
(2009-07-16 17:37:54 UTC)
#1
You need to set reviewers or your issue won't get looked at.
I don't know whether this is the right fix.
Peter Kasting
Pinging this since Glen Murphy is probably the right reviewer but I guess this fell ...
11 years, 4 months ago
(2009-08-20 23:50:31 UTC)
#2
Pinging this since Glen Murphy is probably the right reviewer but I guess this
fell off his radar.
Philippe Beauchamp
I filed the 3x3 pixels offset bug in webkit with a patch. https://bugs.webkit.org/show_bug.cgi?id=28611 I still ...
11 years, 4 months ago
(2009-08-21 13:15:43 UTC)
#3
I filed the 3x3 pixels offset bug in webkit with a patch.
https://bugs.webkit.org/show_bug.cgi?id=28611
I still need to confirm the hotspot position for icons in chromium based on the
webkit modif. I'll post new files soon if they need update.
Peter Kasting
Note that I'm still not sure pan_icon.png should be made 20x20, rather than panIconSizeLength changed ...
11 years, 4 months ago
(2009-08-21 17:37:20 UTC)
#4
Note that I'm still not sure pan_icon.png should be made 20x20, rather than
panIconSizeLength changed to 16. Checking with what Safari does on Mac and
Windows would be helpful.
Peter Kasting
Never mind, I see you did this upstream already.
11 years, 4 months ago
(2009-08-21 17:38:25 UTC)
#5
Never mind, I see you did this upstream already.
Philippe Beauchamp
New patch Updated. Hotspot changed for all 8 cursors. pan_icon.png removed from list because the ...
11 years, 4 months ago
(2009-08-22 20:23:30 UTC)
#6
New patch Updated.
Hotspot changed for all 8 cursors.
pan_icon.png removed from list because the pixel offset is solved in WebKit.
Peter Kasting
OK, let's give this a shot; LGTM. Have you already signed the Committer License Agreement?
11 years, 4 months ago
(2009-08-22 22:46:15 UTC)
#7
OK, let's give this a shot; LGTM. Have you already signed the Committer License
Agreement?
Philippe Beauchamp
Yes On 8/22/09, pkasting@chromium.org <pkasting@chromium.org> wrote: > OK, let's give this a shot; LGTM. Have ...
11 years, 4 months ago
(2009-08-23 01:05:30 UTC)
#8
Well darn. I went to apply this and found that gcl/rietveld don't give me a ...
11 years, 4 months ago
(2009-08-24 21:04:35 UTC)
#9
Well darn. I went to apply this and found that gcl/rietveld don't give me a way
to patch in the raw binary files. Could you send me a .zip? Emailing it to
pkasting@chromium.org is fine.
Peter Kasting
Landed in r24192.
11 years, 4 months ago
(2009-08-25 00:27:47 UTC)
#10
Issue 149742: Hotspot location changed for all cursors to match the icon center....
(Closed)
Created 11 years, 5 months ago by Philippe Beauchamp
Modified 9 years, 7 months ago
Reviewers: Glen Murphy, Peter Kasting
Base URL: http://src.chromium.org/svn/trunk/src/
Comments: 0