Issue 149729: Add some missing hotkeys....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149729: Add some missing hotkeys.... (Closed)

Created:
11 years, 5 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GTK: Add some missing hotkeys. There doesn't seem to be a platform default behavior for shift+scroll (for native apps like epiphany and gedit it vertically scrolls, and for firefox it navigates the back/forward list). Likewise I can't find any default way to get gnome to send a horiztonal scroll event except by having a horiztonal scrollwheel (like on a trackpad or fancy mouse). Also it seems like the direction ought to switch for RTL-encoded pages, but this doesn't appear to happen in windows. Also, fix bug where a ctrl+scroll would scroll AND zoom (which you can test by scrolling to the top of the page then pressing ctrl+down wheel). BUG=16792 TEST=horizontally scroll via shift + Scrollwheel Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21010

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
	M	chrome/browser/gtk/browser_window_gtk.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/renderer_host/render_widget_host_view_gtk.cc	View	1	2 chunks	+14 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

11 years, 5 months ago (2009-07-17 21:36:52 UTC) #6

no worries

-- Evan Stade



On Fri, Jul 17, 2009 at 9:19 PM, <evan@chromium.org> wrote:
> LGTM
>
> (somehow i missed your re-ping, really sorry)
>
> http://codereview.chromium.org/149729
>

Expand Messages | Collapse Messages