Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Issue 149705: Added an observer for 'pref::kDefaultCharset' change I forgot to add in rXXXX... (Closed)

Created:
11 years, 5 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium, Ben Goodger (Google)
Visibility:
Public.

Description

Added an observer for 'pref::kDefaultCharset' change I forgot to add in r15113 (http://src.chromium.org/viewvc/chrome?view=rev&revision=15113) . Besides, set referrer_charset_ (used in guessing the C-D charset in GetFileNameFromCD) to pref::kDefaultCharset without any q values appended. TEST=1. Set the default charset in Options | Advanced | Fonts & Languages to ISO-8859-1. 2. Type http://i18nl10n.com/moztest/random21.yyy in the omnibox and the filename in the download bar should start with "ÇѱÛ21" 3. Change the default charset to Korean 4. Try #2 again and the filename in the download bar should start with '한글21'. BUG=1148 (http://crbug.com/1148 ) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20965

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M chrome/browser/net/chrome_url_request_context.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 1 2 6 chunks +23 lines, -3 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
jungshik at Google
11 years, 5 months ago (2009-07-16 00:05:08 UTC) #1
wtc
LGTM. http://codereview.chromium.org/149705/diff/1006/1007 File chrome/browser/net/chrome_url_request_context.cc (right): http://codereview.chromium.org/149705/diff/1006/1007#newcode291 Line 291: referrer_charset_ = default_charset; Question: so referrer_charset_ should ...
11 years, 5 months ago (2009-07-16 01:14:47 UTC) #2
jungshik at Google
11 years, 5 months ago (2009-07-16 06:48:23 UTC) #3
2009/7/15  <wtc@chromium.org>:
> LGTM.

thank you for the review.

>
> http://codereview.chromium.org/149705/diff/1006/1007
> File chrome/browser/net/chrome_url_request_context.cc (right):
>
> http://codereview.chromium.org/149705/diff/1006/1007#newcode291
> Line 291: referrer_charset_ = default_charset;
> Question: so referrer_charset_ should contain a single
> charset and should not have the 'q' value?

yes. it's not sent over to a server but just used internally by us (net_utils).


>
> http://codereview.chromium.org/149705
>

Powered by Google App Engine
This is Rietveld 408576698