Code changes to get the code to compile under GCC....

Code changes to get the code to compile under GCC.

Courgette still only knows how to compress Windows x86 executables.
But now you can compress them on linux.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21042

[cpu_(ooo_6.6-7.5), 2009-07-14 21:19:23]

LGTM, some nits below..

http://codereview.chromium.org/149597/diff/1041/1054
File courgette/courgette_minimal_tool.cc (right):

http://codereview.chromium.org/149597/diff/1041/1054#newcode41
Line 41: {
lint wants the { above each.

http://codereview.chromium.org/149597/diff/1041/1043
File courgette/courgette_tool.cc (right):

http://codereview.chromium.org/149597/diff/1041/1043#newcode53
Line 53: file_path = file_path;
??

http://codereview.chromium.org/149597/diff/1041/1043#newcode72
Line 72: Problem("Cant write output.");
Can't

http://codereview.chromium.org/149597/diff/1041/1055
File courgette/encoded_program_fuzz_unittest.cc (right):

http://codereview.chromium.org/149597/diff/1041/1055#newcode191
Line 191: EXPECT_NE(0u, changed_byte_count);   //   ... we expect some
difference.
uppercase U?

http://codereview.chromium.org/149597/diff/1041/1052
File courgette/image_info_unittest.cc (right):

http://codereview.chromium.org/149597/diff/1041/1052#newcode67
Line 67: EXPECT_EQ(449536u, info->size_of_code());
U

http://codereview.chromium.org/149597/diff/1041/1050
File courgette/streams.cc (right):

http://codereview.chromium.org/149597/diff/1041/1050#newcode21
Line 21: // #include <io.h>
remove line

http://codereview.chromium.org/149597/diff/1041/1056
File courgette/streams_unittest.cc (right):

http://codereview.chromium.org/149597/diff/1041/1056#newcode45
Line 45: EXPECT_EQ(0u, source.Remaining());
U

http://codereview.chromium.org/149597/diff/1041/1056#newcode72
Line 72: EXPECT_EQ(0u, in.stream(2)->Remaining());
U

http://codereview.chromium.org/149597/diff/1041/1056#newcode114
Line 114: EXPECT_EQ(0u, in.stream(i)->Remaining());
U

http://codereview.chromium.org/149597/diff/1041/1056#newcode146
Line 146: EXPECT_EQ(true, can_read);
EXPECT_TRUE?

http://codereview.chromium.org/149597/diff/1041/1056#newcode201
Line 201: EXPECT_EQ(60000u, datum);
U (other above as well)

[sra, 2009-07-14 23:03:04]

Done all.  Will submit when the tree is open.

http://codereview.chromium.org/149597/diff/1041/1054
File courgette/courgette_minimal_tool.cc (right):

http://codereview.chromium.org/149597/diff/1041/1054#newcode41
Line 41: {
On 2009/07/14 21:19:24, cpu wrote:
> lint wants the { above each.

Done.
But it confuses the editor.

http://codereview.chromium.org/149597/diff/1041/1043
File courgette/courgette_tool.cc (right):

http://codereview.chromium.org/149597/diff/1041/1043#newcode53
Line 53: file_path = file_path;
On 2009/07/14 21:19:24, cpu wrote:
> ??

Done - removed.

http://codereview.chromium.org/149597/diff/1041/1043#newcode72
Line 72: Problem("Cant write output.");
On 2009/07/14 21:19:24, cpu wrote:
> Can't

Done.

http://codereview.chromium.org/149597/diff/1041/1055
File courgette/encoded_program_fuzz_unittest.cc (right):

http://codereview.chromium.org/149597/diff/1041/1055#newcode191
Line 191: EXPECT_NE(0u, changed_byte_count);   //   ... we expect some
difference.
On 2009/07/14 21:19:24, cpu wrote:
> uppercase U?

I will use 'U' for consistency, and because it is more 'normal'.  I like 'u'
because 'U' looks too much like a digit.  I like ADA even more - you can put
underscores in numeric literals :-)

What we really need is a smarter compiler that warnings on signed/unsigned when
no harm can come of it.

http://codereview.chromium.org/149597/diff/1041/1052
File courgette/image_info_unittest.cc (right):

http://codereview.chromium.org/149597/diff/1041/1052#newcode67
Line 67: EXPECT_EQ(449536u, info->size_of_code());
On 2009/07/14 21:19:24, cpu wrote:
> U

Done.

http://codereview.chromium.org/149597/diff/1041/1050
File courgette/streams.cc (right):

http://codereview.chromium.org/149597/diff/1041/1050#newcode21
Line 21: // #include <io.h>
On 2009/07/14 21:19:24, cpu wrote:
> remove line

Done.

http://codereview.chromium.org/149597/diff/1041/1056
File courgette/streams_unittest.cc (right):

http://codereview.chromium.org/149597/diff/1041/1056#newcode45
Line 45: EXPECT_EQ(0u, source.Remaining());
On 2009/07/14 21:19:24, cpu wrote:
> U

Done.

http://codereview.chromium.org/149597/diff/1041/1056#newcode72
Line 72: EXPECT_EQ(0u, in.stream(2)->Remaining());
On 2009/07/14 21:19:24, cpu wrote:
> U

Done.

http://codereview.chromium.org/149597/diff/1041/1056#newcode114
Line 114: EXPECT_EQ(0u, in.stream(i)->Remaining());
On 2009/07/14 21:19:24, cpu wrote:
> U

Done.

http://codereview.chromium.org/149597/diff/1041/1056#newcode201
Line 201: EXPECT_EQ(60000u, datum);
On 2009/07/14 21:19:24, cpu wrote:
> U (other above as well)

Done.

[M-A Ruel, 2009-08-04 16:47:02]

On 2009/07/14 23:03:04, sra wrote:
> Done all.  Will submit when the tree is open.

YOU FORGOT TO SVN:IGNORE THE GENERATED PROJECT FILES. (I'll do because you're
not alone)

[sra1, 2009-08-04 17:15:46]

Is there a presubmit check for this?  I didn't notice a warning.

On Tue, Aug 4, 2009 at 9:47 AM, <maruel@chromium.org> wrote:

> On 2009/07/14 23:03:04, sra wrote:
>
>> Done all.  Will submit when the tree is open.
>>
>
> YOU FORGOT TO SVN:IGNORE THE GENERATED PROJECT FILES. (I'll do because
> you're not alone)
>
> http://codereview.chromium.org/149597
>

[M-A Ruel, 2009-08-04 17:18:08]

No, we (actually, the guy just beside me) will fix
http://crbug.com/15924 instead.

Oh, there's no one beside me.

M-A

On Tue, Aug 4, 2009 at 1:15 PM, Stephen Adams<sra@google.com> wrote:
> Is there a presubmit check for this? =C2=A0I didn't notice a warning.
>
> On Tue, Aug 4, 2009 at 9:47 AM, <maruel@chromium.org> wrote:
>>
>> On 2009/07/14 23:03:04, sra wrote:
>>>
>>> Done all. =C2=A0Will submit when the tree is open.
>>
>> YOU FORGOT TO SVN:IGNORE THE GENERATED PROJECT FILES. (I'll do because
>> you're not alone)
>>
>> http://codereview.chromium.org/149597
>
>