Issue 149484: Fixed compile breakage resulting from wstring to string16 change....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149484: Fixed compile breakage resulting from wstring to string16 change.... (Closed)

Created:
11 years, 5 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixed compile breakage resulting from wstring to string16 change. BUG=none TEST=none TBR=ben Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20431

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/views/panel_controller.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

11 years, 5 months ago (2009-07-10 22:21:51 UTC) #2

OK

On Fri, Jul 10, 2009 at 2:49 PM, <sky@chromium.org> wrote:
> Reviewers: Ben Goodger,
>
> Description:
> Fixed compile breakage resulting from wstring to string16 change.
>
> BUG=3Dnone
> TEST=3Dnone
> TBR=3Dben
>
> Please review this at http://codereview.chromium.org/149484
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 chrome/browser/views/panel_controller.cc
>
>
> Index: chrome/browser/views/panel_controller.cc
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/browser/views/panel_controller.cc =A0 =A0(revision 20414)
> +++ chrome/browser/views/panel_controller.cc =A0 =A0(working copy)
> @@ -13,6 +13,7 @@
> =A0#include "base/logging.h"
> =A0#include "base/singleton.h"
> =A0#include "base/scoped_ptr.h"
> +#include "base/string_util.h"
> =A0#include "chrome/browser/browser.h"
> =A0#include "chrome/browser/gtk/browser_window_gtk.h"
> =A0#include "chrome/browser/views/tabs/tab_overview_types.h"
> @@ -95,7 +96,7 @@
>
> =A0void PanelController::UpdateTitleBar() {
> =A0 title_content_->title_label()->SetText(
> - =A0 =A0 =A0browser_window_->browser()->GetCurrentPageTitle());
> + =A0 =A0 =A0UTF16ToWideHack(browser_window_->browser()->GetCurrentPageTi=
tle()));
> =A0}
>
> =A0bool PanelController::TitleMousePressed(const views::MouseEvent& event=
) {
>
>
>

Expand Messages | Collapse Messages