Convert JavascriptAlertActivatesTab to browser_tests framework.

Convert JavascriptAlertActivatesTab to browser_tests framework.

This should make it non-flaky, so I un-disabled the test. I also added necessary plumbing so we can
wait for AppModalDialog to appear and close it.

TEST=Covered by browser_tests.
http://crbug.com/16062

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20400

[Nicolas Sylvain, 2009-07-10 18:07:54]

this change LGTM

[sky, 2009-07-10 18:22:51]

http://codereview.chromium.org/149460/diff/1/2
File chrome/browser/app_modal_dialog.cc (right):

http://codereview.chromium.org/149460/diff/1/2#newcode94
Line 94: NotificationService::current()->Notify(
This is a lot to duplicate three times. How about a method (or static function)?

[Paweł Hajdan Jr., 2009-07-10 18:50:48]

On 2009/07/10 18:22:51, sky wrote:
> http://codereview.chromium.org/149460/diff/1/2
> File chrome/browser/app_modal_dialog.cc (right):
> 
> http://codereview.chromium.org/149460/diff/1/2#newcode94
> Line 94: NotificationService::current()->Notify(
> This is a lot to duplicate three times. How about a method (or static
function)?

Done.

[sky, 2009-07-10 19:27:05]

LGTM with the following removed.

http://codereview.chromium.org/149460/diff/1009/1014
File chrome/common/notification_type.h (right):

http://codereview.chromium.org/149460/diff/1009/1014#newcode209
Line 209: TAB_LANGUAGE_DETERMINED,
did you intend to include this in this cr?

[Paweł Hajdan Jr., 2009-07-10 19:34:08]

On 2009/07/10 19:27:05, sky wrote:
> LGTM with the following removed.
> 
> http://codereview.chromium.org/149460/diff/1009/1014
> File chrome/common/notification_type.h (right):
> 
> http://codereview.chromium.org/149460/diff/1009/1014#newcode209
> Line 209: TAB_LANGUAGE_DETERMINED,
> did you intend to include this in this cr?

It's not a part of this cr. I just rebased between Patch Set 1 and Patch Set 2.

[sky, 2009-07-10 19:47:38]

My mistake, LGTM.