Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Unified Diff: chrome/browser/browser_uitest.cc

Issue 149460: Convert JavascriptAlertActivatesTab to browser_tests framework. (Closed)
Patch Set: kill duplication Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_uitest.cc
diff --git a/chrome/browser/browser_uitest.cc b/chrome/browser/browser_uitest.cc
index a65499f1117f0292b764aa89e7d7379dc937e530..57fc6b5e99aebfd376c7d9578ff061c324c67ebd 100644
--- a/chrome/browser/browser_uitest.cc
+++ b/chrome/browser/browser_uitest.cc
@@ -113,25 +113,6 @@ TEST_F(BrowserTest, WindowsSessionEnd) {
}
#endif
-// This test is flakey, see bug 5668 for details.
-TEST_F(BrowserTest, DISABLED_JavascriptAlertActivatesTab) {
- scoped_refptr<BrowserProxy> window(automation()->GetBrowserWindow(0));
- int start_index;
- ASSERT_TRUE(window->GetActiveTabIndex(&start_index));
- ASSERT_TRUE(window->AppendTab(GURL("about:blank")));
- int javascript_tab_index;
- ASSERT_TRUE(window->GetActiveTabIndex(&javascript_tab_index));
- scoped_refptr<TabProxy> javascript_tab = window->GetActiveTab();
- ASSERT_TRUE(javascript_tab.get());
- // Switch back to the starting tab, then send the second tab a javascript
- // alert, which should force it to become active.
- ASSERT_TRUE(window->ActivateTab(start_index));
- ASSERT_TRUE(
- javascript_tab->NavigateToURLAsync(GURL("javascript:alert('Alert!')")));
- ASSERT_TRUE(window->WaitForTabToBecomeActive(javascript_tab_index,
- action_max_timeout_ms()));
-}
-
// Test that scripts can fork a new renderer process for a tab in a particular
// case (which matches following a link in Gmail). The script must open a new
// tab, set its window.opener to null, and redirect it to a cross-site URL.

Powered by Google App Engine
This is Rietveld 408576698