Remove the descriptor stream abstractions....

Remove the descriptor stream abstractions.

The abstractions have led to bugs because it looks like descriptor
streams are GC safe but they are not.

I have moved the descriptor stream helper functions to descriptor
arrays and I find most of the code just as readable now as it was
before.

Committed: http://code.google.com/p/v8/source/detail?r=2428

[iposva, 2009-07-10 16:36:15]

LGTM -ip

http://codereview.chromium.org/149458/diff/1/11
File src/factory.cc (right):

http://codereview.chromium.org/149458/diff/1/11#newcode575
Line 575: result->SetFrom(descriptor_count++, *array, i);
This would probably be more readable if SetFrom was renamed to CopyFrom, which
to me indicates that you are copying an entry from one descriptor array to the
target index.

http://codereview.chromium.org/149458/diff/1/11#newcode595
Line 595: // We do not use a DescriptorWriter because SymbolFromString can
The DescriptorWriter comment is now outdated here.

[Mads Ager (chromium), 2009-07-10 19:21:08]

http://codereview.chromium.org/149458/diff/1/11
File src/factory.cc (right):

http://codereview.chromium.org/149458/diff/1/11#newcode575
Line 575: result->SetFrom(descriptor_count++, *array, i);
On 2009/07/10 16:36:15, iposva wrote:
> This would probably be more readable if SetFrom was renamed to CopyFrom, which
> to me indicates that you are copying an entry from one descriptor array to the
> target index.

I agree.  Thanks.

http://codereview.chromium.org/149458/diff/1/11#newcode595
Line 595: // We do not use a DescriptorWriter because SymbolFromString can
On 2009/07/10 16:36:15, iposva wrote:
> The DescriptorWriter comment is now outdated here.

Whoops, done.