Fix DnD jank...

Fix DnD jank

The mouseover code I added to do *smart* tooltips was making DnD almost
unusable.

BUG=None

TEST=Drag thumbnails on the NNTP and they should move smoothly.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20413

[arv (Not doing code reviews), 2009-07-10 17:42:44]

Ping?

On Thu, Jul 9, 2009 at 16:23, <arv@chromium.org> wrote:
> Reviewers: Glen Murphy,
>
> Description:
> Fix DnD jank
>
> The mouseover code I added to do *smart* tooltips was making DnD almost
> unusable.
>
> BUG=3DNone
>
> TEST=3DDrag thumbnails on the NNTP and they should move smoothly.
>
>
> Please review this at http://codereview.chromium.org/149427
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =C2=A0M =C2=A0 =C2=A0 chrome/browser/resources/new_new_tab.js
>
>
> Index: chrome/browser/resources/new_new_tab.js
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- chrome/browser/resources/new_new_tab.js =C2=A0 =C2=A0 (revision 20158=
)
> +++ chrome/browser/resources/new_new_tab.js =C2=A0 =C2=A0 (working copy)
> @@ -1055,6 +1055,12 @@
>
> =C2=A0// Tooltip for elements that have text that overflows.
> =C2=A0document.addEventListener('mouseover', function(e) {
> + =C2=A0// We don't want to do this while we are dragging because it make=
s things
> very
> + =C2=A0// janky
> + =C2=A0if (dnd.dragItem) {
> + =C2=A0 =C2=A0return;
> + =C2=A0}
> +
> =C2=A0 var el =3D findAncestor(e.target, function(el) {
> =C2=A0 =C2=A0 return el.xtitle;
> =C2=A0 });
>
>
>



--=20
erik

[Glen Murphy, 2009-07-10 20:48:44]

LGTM, sorry