Issue 149407: Make the printint_unittest use the correct test harness. This removes the ne...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149407: Make the printint_unittest use the correct test harness. This removes the ne... (Closed)

Created:
11 years, 5 months ago by Sverrir

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make the printint_unittest use the correct test harness. This removes the need for an AtExitManager in one of the tests (which is just plain wrong). BUG=none TEST=no functional change (printing_unittests should run successfully). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20319

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -5 lines)			Patch
M	printing/page_overlays_unittest.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	printing/printing.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	printing/run_all_unittests.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sverrir

As discussed in the review thread (http://codereview.chromium.org/149212).

11 years, 5 months ago (2009-07-09 20:28:10 UTC) #1

Yay, thanks

Expand Messages | Collapse Messages