Move printing related stuff to the root printing project from the browser pro...

Move printing related stuff to the root printing project from the browser project.  This simplifies further refactoring and eases understanding of the printing part of Chrome.
Also renamed win_printing_context to printing_context_win (correct naming convention) and added stub implementations for _linux and mac.
Now all but one file is compiling on all platforms.

TEST=none (no functional change).
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20086

[Sverrir, 2009-07-07 15:16:27]

Continued refactoring of the printing stuff.  Some of the unit tests for
printing are now running on mac's & linux.  Next step is to gradually make more
of it compile and run on those platforms.
I had to add dependency on the /app library which I did not like but the font
functionality is there so I don't see any other way of solving that.

[M-A Ruel, 2009-07-07 16:16:50]

nit: Can you add printing/printing_context_linux.cc and _mac.cc right now with
the corresponding stub member functions calling NOTIMPLEMENTED?

lgtm

http://codereview.chromium.org/149212/diff/378/1255
File printing/page_number.h (right):

http://codereview.chromium.org/149212/diff/378/1255#newcode5
Line 5: #ifndef PRINTING_PAGE_NUMBER_H__
PRINTING_PAGE_NUMBER_H_ and others

http://codereview.chromium.org/149212/diff/378/1259
File printing/page_overlays_unittest.cc (right):

http://codereview.chromium.org/149212/diff/378/1259#newcode17
Line 17: base::AtExitManager global_at_exit_manager;
No you need to put it in each test.

[Mohamed Mansour, 2009-07-07 16:33:54]

The patch isn't actually moving (if you look at the .patch file) the files are
not moving to the new location.

[Sverrir, 2009-07-07 20:29:49]

Added printing_context_linux and _mac.  Now everything compiles except for
printed_document on all platforms.
Fixed minor gcc compilation issues (nested templates and order  of
initialization of member variables).

http://codereview.chromium.org/149212/diff/378/1255
File printing/page_number.h (right):

http://codereview.chromium.org/149212/diff/378/1255#newcode5
Line 5: #ifndef PRINTING_PAGE_NUMBER_H__
On 2009/07/07 16:16:51, Marc-Antoine Ruel wrote:
> PRINTING_PAGE_NUMBER_H_ and others

Done.

http://codereview.chromium.org/149212/diff/378/1259
File printing/page_overlays_unittest.cc (right):

http://codereview.chromium.org/149212/diff/378/1259#newcode17
Line 17: base::AtExitManager global_at_exit_manager;
On 2009/07/07 16:16:51, Marc-Antoine Ruel wrote:
> No you need to put it in each test.

The test failed without this (no AtExitManager).

[M-A Ruel, 2009-07-07 20:52:44]

http://codereview.chromium.org/149212/diff/450/456
File printing/page_overlays_unittest.cc (right):

http://codereview.chromium.org/149212/diff/450/456#newcode17
Line 17: base::AtExitManager global_at_exit_manager;
I don't understand your comment. I meant moving this line to line 54.

http://codereview.chromium.org/149212/diff/450/472
File printing/printing_context_win_unittest.cc (right):

http://codereview.chromium.org/149212/diff/450/472#newcode23
Line 23: ;
this line is strange.

[Sverrir, 2009-07-07 21:22:58]

http://codereview.chromium.org/149212/diff/450/456
File printing/page_overlays_unittest.cc (right):

http://codereview.chromium.org/149212/diff/450/456#newcode17
Line 17: base::AtExitManager global_at_exit_manager;
On 2009/07/07 20:52:44, Marc-Antoine Ruel wrote:
> I don't understand your comment. I meant moving this line to line 54.

The failure is in PageOverlyTest construction so it's to late to add it in the
start of the test.  Adding it to the constructor seems a bit to involved for me.
I will leave it here for now.

http://codereview.chromium.org/149212/diff/450/472
File printing/printing_context_win_unittest.cc (right):

http://codereview.chromium.org/149212/diff/450/472#newcode23
Line 23: ;
Removed

[M-A Ruel, 2009-07-09 19:27:58]

A bit late but still, the global_at_exit_manager should be fixed in a subsequent
patch.

http://codereview.chromium.org/149212/diff/450/507
File chrome/browser/renderer_host/resource_message_filter.cc (right):

http://codereview.chromium.org/149212/diff/450/507#newcode119
Line 119: #if defined(OS_WIN)
Actually, why OS_WIN? I don't see much platform specific code there.

http://codereview.chromium.org/149212/diff/450/456
File printing/page_overlays_unittest.cc (right):

http://codereview.chromium.org/149212/diff/450/456#newcode17
Line 17: base::AtExitManager global_at_exit_manager;
Still, you can't check that in. It affects every other tests in the executable.
You can make it member of PageOverlaysTest though.

[Sverrir, 2009-07-09 20:13:23]

http://codereview.chromium.org/149212/diff/450/507
File chrome/browser/renderer_host/resource_message_filter.cc (right):

http://codereview.chromium.org/149212/diff/450/507#newcode119
Line 119: #if defined(OS_WIN)
On 2009/07/09 19:27:59, Marc-Antoine Ruel wrote:
> Actually, why OS_WIN? I don't see much platform specific code there.

Currently this file is including the temp_scaffolding_stubs.h (where these
member variables are not defined).   I will check if can do a quick fix to that.
 I will send in a separate change if so.

http://codereview.chromium.org/149212/diff/450/456
File printing/page_overlays_unittest.cc (right):

http://codereview.chromium.org/149212/diff/450/456#newcode17
Line 17: base::AtExitManager global_at_exit_manager;
On 2009/07/09 19:27:59, Marc-Antoine Ruel wrote:
> Still, you can't check that in. It affects every other tests in the
executable.
> You can make it member of PageOverlaysTest though.

Figured it out.  printing_unittest was not using the right test harness. 
Sending another changelist for this.