Issue 149375: Not build StorageArea.cpp in webkit.gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149375: Not build StorageArea.cpp in webkit.gyp (Closed)

Created:
11 years, 5 months ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
jorlow

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Not build StorageArea.cpp in webkit.gyp TBR=jorlow Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20221

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	webkit/webkit.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jorlow

11 years, 5 months ago (2009-07-09 00:51:26 UTC) #2

LGTM

On Wed, Jul 8, 2009 at 5:50 PM, <hclam@chromium.org> wrote:

> Reviewers: Jeremy Orlow,
>
> Description:
> Not build StorageArea.cpp in webkit.gyp
> TBR=jorlow
>
>
> Please review this at http://codereview.chromium.org/149375
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     webkit/webkit.gyp
>
>
> Index: webkit/webkit.gyp
> ===================================================================
> --- webkit/webkit.gyp   (revision 20220)
> +++ webkit/webkit.gyp   (working copy)
> @@ -3407,7 +3407,6 @@
>         '../third_party/WebKit/WebCore/storage/SessionStorageArea.h',
>         '../third_party/WebKit/WebCore/storage/Storage.cpp',
>         '../third_party/WebKit/WebCore/storage/Storage.h',
> -        '../third_party/WebKit/WebCore/storage/StorageArea.cpp',
>         '../third_party/WebKit/WebCore/storage/StorageArea.h',
>         '../third_party/WebKit/WebCore/storage/StorageEvent.cpp',
>         '../third_party/WebKit/WebCore/storage/StorageEvent.h',
>
>
>

Expand Messages | Collapse Messages